build: bump jackson version #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pipeline:run |
Vovchyk
force-pushed
the
vovchyk/jackson-ver-bump
branch
from
ac1af7a to
afba7c0
Compare
fmacleal
approved these changes
Sep 16, 2024
Comment on lines
+184
to
+191
| int depth = 998; | ||
| StringBuilder sb = new StringBuilder(content.length() + 2*depth); | ||
| for (long i = 0; i < depth; i++) { | ||
| sb.append("["); | ||
| } | ||
| sb.append(content); | ||
| for (long i = 0; i < depth; i++) { | ||
| sb.append("]"); |
There was a problem hiding this comment.
question:
Is it optimising because isn't necessary a loop big how was it? Did you had to change because it was failing? What's the reason for the change?
There was a problem hiding this comment.
you're right. basically to improve perf of the test a bit. This test was hanging a bit
Vovchyk
force-pushed
the
vovchyk/jackson-ver-bump
branch
from
5a3bfe9 to
101110a
Compare
Vovchyk
force-pushed
the
vovchyk/jackson-ver-bump
branch
from
101110a to
e0cb416
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
2.15.4StreamConstraintsExceptionexception (which was introduced in the newer version)in the
JsonRpcWeb3ServerHandlerclassMotivation and Context
How Has This Been Tested?
Types of changes
Checklist:
fed:vovchyk/jackson-ver-bump