C API: support shell-style variable substitution #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework `dnf_repo_substitute` to call the C++ API's ConfigParser::substitute instead of librepo's lr_url_substitute. Resolves rpm-software-management#1690
Conan-Kudo
approved these changes
Feb 7, 2025
|
The failing tests are not related and they pass locally. |
kontura
merged commit 01b3f2c
into
rpm-software-management:dnf-4-master
7 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework
dnf_repo_substituteto call the C++ API'sConfigParser::substituteinstead of librepo'slr_url_substitute. This brings support for shell-style variable expressions to the C API, which was added to the C++ API in #1622.We could instead add support for the shell-style variable substitution in librepo's
lr_url_substitute, which might have additional benefits elsewhere, but it would take more development time, risk breaking something, and create yet another implementation of this feature.Resolves #1690.