This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Pass macro dep to cppcheck #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
|
CI |
ivanpauno
approved these changes
Aug 27, 2020
rotu
added a commit
to rotu/ament_lint
that referenced
this pull request
Aug 30, 2020
Previously the logic did not handle generator expressions in a consistent way and required users to add recursive dependencies to cppcheck e.g. ros2/rosidl_typesupport_connext#57 . This should fix that. Performance impact should be assessed.
rotu
added a commit
to rotu/ament_lint
that referenced
this pull request
Aug 30, 2020
Previously the logic did not handle generator expressions in a consistent way and required users to add recursive dependencies to cppcheck e.g. ros2/rosidl_typesupport_connext#57 . This should fix that. Performance impact should be assessed. Signed-off-by: Dan Rose <dan@digilabs.io>
sloretz
approved these changes
Nov 5, 2020
|
@claireyywang ping |
|
Closing this, since we aren't going to backport this to Foxy and we no longer use this package in Galactic and Rolling. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of the effort to pin cppcheck 2.0, ros2/ros2#942
Signed-off-by: claireyywang 22240514+claireyywang@users.noreply.github.com