-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
supplement how to use Loaned Messages. #5068
base: rolling
Are you sure you want to change the base?
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@christophebedard @MiguelCompany can you review this? Note We can backport this as it is to jazzy and humble. |
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/13682385638/artifacts/2698157881. To view the resulting site:
|
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@MiguelCompany i addressed your comment, could you take a look again? thanks in advance. |
We should at least point out this critical bug: ros2/rclcpp#2401 |
@alsora i think the problem is already linked in https://docs.ros.org/en/humble/How-To-Guides/Configure-ZeroCopy-loaned-messages.html#subscriptions to disable loaned message on subscription side. but i can also add ros2/rmw_cyclonedds#469 to the doc too. |
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
|
Thanks, I didn't notice that it was already there at the end of the file. My understanding is that as of today, loaned messages do not allow to achieve zero copy because as that ticket points out, they are disabled in subscriptions (and are unsafe to enable). Advertising a broken feature can be dangerous. Are there advantages in using this feature until that bug is resolved? |
yeah, right there could be consequences on the subscription if user changes the setting from default, that is why in default it copies the message data from middleware. but how about publisher aspect? i thought that is still benefic for user application as a feature and it is safe as long as being with default setting? what i am trying to add here is to add general explanation about |
ROS 2 documentation does not really explains how to use
LoanedMessages
or demonstration but only how to disable it.It would be better to add more general description about
LoanedMessages
including RMW implementation support status.