-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Visualizing-ROS-2-Data-With-Foxglove-Studio.rst #5053
base: jazzy
Are you sure you want to change the base?
Conversation
add note about Foxglove no longer being open source, and provide info on a suitable alternative. Signed-off-by: edgimar <edgimar@gmail.com>
@@ -1,7 +1,9 @@ | |||
Visualizing ROS 2 data with Foxglove Studio | |||
=========================================== | |||
|
|||
`Foxglove Studio <https://foxglove.dev/studio>`__ is an open source visualization and debugging tool for your robotics data. | |||
`Foxglove Studio <https://foxglove.dev/studio>`__ is an open closed source visualization and debugging tool for your robotics data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing open source
is correct here, how about the following?
`Foxglove Studio <https://foxglove.dev/studio>`__ is an open closed source visualization and debugging tool for your robotics data. | |
`Foxglove Studio <https://foxglove.dev/studio>`__ is a visualization and observability platform for robotics development. |
`Foxglove Studio <https://foxglove.dev/studio>`__ is an open source visualization and debugging tool for your robotics data. | ||
`Foxglove Studio <https://foxglove.dev/studio>`__ is an open closed source visualization and debugging tool for your robotics data. | ||
|
||
**NOTE: Foxglove Studio is no longer open-source. An open-source alternative that also supports the MCAP file format is** `Rerun.io <https://rerun.io>`__ , **with source code available at https://github.com/rerun-io/rerun.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the dedicated documentation how to use foxglobe studio with ROS 2.
IMO if we want to introduce rerun
, we should have dedicated and whole procedure how to use rerun
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I concur here. While I think it is fine to mention that Foxglove is closed source and that there are open source alternatives it is pretty unsatisfying that there is no documentation to point the end user to.
The Rerun team is pretty friendly, I'll give them a ping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I heard back from Rerun. According to them, "I unfortunately wouldn't say that we're all the way there to be able to claim that Rerun has out of the box support for mcap files with ROS 2 messages yet."
Given that this is straight from the project maintainer I would be reluctant to point users in the direction of Rerun. @edgimar I appreciate the spirit of this PR, but given this information I recommend that we not merge your pull request. We would be happy to have your help on some other docs issues though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kscottz, that makes sense to me. Do you think the page should be updated so it accurately communicates the open/closed-source status of Foxglove?
add note about Foxglove no longer being open source, and provide info on a suitable alternative.