Improving possible confusing instructions #4124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instruction tell the reader to search and replace USERNAME in 2 scripts. But some USERNAME strings should not be replaced. Changed the string that need to be replaced with YOUR_USERNAME and changed the instructions to match that. Signed-off-by: Tim <timbosschaerts@gmail.com>
source/How-To-Guides/Setup-ROS-2-with-VSCode-and-Docker-Container.rst
Outdated
Show resolved
Hide resolved
source/How-To-Guides/Setup-ROS-2-with-VSCode-and-Docker-Container.rst
Outdated
Show resolved
Hide resolved
source/How-To-Guides/Setup-ROS-2-with-VSCode-and-Docker-Container.rst
Outdated
Show resolved
Hide resolved
source/How-To-Guides/Setup-ROS-2-with-VSCode-and-Docker-Container.rst
Outdated
Show resolved
Hide resolved
I tested and it works now for me. What I was doing wrong before was not putting my devcontainer.json in a ./devcontainer folder. In that case the passing of args from devcontainer to dockerfile break apparently. Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Tim <timbosschaerts@gmail.com>
revert Dockerfile to original. Signed-off-by: Tim <timbosschaerts@gmail.com>
fujitatomoya
approved these changes
Jan 23, 2024
clalancette
added
the
backport-all
clalancette
approved these changes
Jan 24, 2024
|
@Mergifyio backport rolling humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
* Improving possible confusing instructions The instruction tell the reader to search and replace USERNAME in 2 scripts. But some USERNAME strings should not be replaced. Changed the string that need to be replaced with YOUR_USERNAME and changed the instructions to match that. Signed-off-by: Tim <timbosschaerts@gmail.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit fecf496)
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
* Improving possible confusing instructions The instruction tell the reader to search and replace USERNAME in 2 scripts. But some USERNAME strings should not be replaced. Changed the string that need to be replaced with YOUR_USERNAME and changed the instructions to match that. Signed-off-by: Tim <timbosschaerts@gmail.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit fecf496)
This was referenced Jan 24, 2024
clalancette
pushed a commit
that referenced
this pull request
Jan 24, 2024
* Improving possible confusing instructions The instruction tell the reader to search and replace USERNAME in 2 scripts. But some USERNAME strings should not be replaced. Changed the string that need to be replaced with YOUR_USERNAME and changed the instructions to match that. Signed-off-by: Tim <timbosschaerts@gmail.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit fecf496) Co-authored-by: Tim <timbosschaerts@gmail.com>
clalancette
pushed a commit
that referenced
this pull request
Jan 24, 2024
* Improving possible confusing instructions The instruction tell the reader to search and replace USERNAME in 2 scripts. But some USERNAME strings should not be replaced. Changed the string that need to be replaced with YOUR_USERNAME and changed the instructions to match that. Signed-off-by: Tim <timbosschaerts@gmail.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit fecf496) Co-authored-by: Tim <timbosschaerts@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instruction tell the reader to search and replace USERNAME in 2 scripts. But some USERNAME strings should not be replaced. Changed the string that need to be replaced with YOUR_USERNAME and changed the instructions to match that.