Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace RuntimeError with new custom exception RCLError #478

Merged
merged 23 commits into from
Dec 10, 2019
Merged

Replace RuntimeError with new custom exception RCLError #478

merged 23 commits into from
Dec 10, 2019

Conversation

suab321321
Copy link
Contributor

@suab321321 suab321321 commented Dec 6, 2019 •
edited by jacobperron
Loading

Fixes #31

Replacing RuntimeError with new custom exception RCLError.

@suab321321 suab321321 mentioned this pull request Dec 6, 2019
Closed
@jacobperron
Copy link
Member

@suab321321 Thanks for the patch! It looks like there was some git branching issues, so I've updated your branch customexception to just contain the one commit I think you wanted.

Also, for the future, it's good to populate the description and title with useful information (for example, a reference to the ticket this is fixing). I have updated the description for you this time.

@jacobperron jacobperron changed the title Customexception Replace RuntimeError with new custom exception RCLError Dec 6, 2019
@suab321321
Copy link
Contributor Author

@jacobperron thank you sir.. I will keep this in mind..will this be merged now sir?

jacobperron
jacobperron reviewed Dec 6, 2019
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some places where I don't think using RCLError is right, since the error is not caused by rcl.

@jacobperron jacobperron self-assigned this Dec 6, 2019
@suab321321
Copy link
Contributor Author

@jacobperron sir I m just comitting the suggested changes from here.

allenh1
allenh1 reviewed Dec 9, 2019
View reviewed changes
jacobperron
jacobperron reviewed Dec 9, 2019
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more things. And after addressing @allenh1's comments, I'll trigger CI.

@suab321321
Copy link
Contributor Author

@jacobperron done sir.....

allenh1
allenh1 reviewed Dec 9, 2019
View reviewed changes
suab321321 and others added 16 commits December 10, 2019 11:12
@suab321321 @jacobperron
Create custom exceptions in _rclpy.c
6af1741 
Signed-off-by: AbhinavSingh <singhabhinav9051571833@gmail.com>
@suab321321 @jacobperron
Update rclpy/src/rclpy/_rclpy.c
db9fd82 
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
@suab321321 @jacobperron
Update rclpy/src/rclpy/_rclpy.c
f3815f5 
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
@suab321321 @jacobperron
Update rclpy/src/rclpy/_rclpy.c
9bd43bf 
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
@suab321321 @jacobperron
Update rclpy/src/rclpy/_rclpy.c
4d1d727 
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
@suab321321 @jacobperron
Update rclpy/src/rclpy/_rclpy.c
c07f4e8 
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
@suab321321 @jacobperron
Update rclpy/src/rclpy/_rclpy.c
e94f78c 
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
@suab321321 @jacobperron
Update rclpy/src/rclpy/_rclpy.c
395e62e 
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
@suab321321 @jacobperron
Update rclpy/src/rclpy/_rclpy.c
c4577de 
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
@suab321321 @jacobperron
Update rclpy/src/rclpy/_rclpy.c
8b8cccf 
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
@suab321321 @jacobperron
Update rclpy/src/rclpy/_rclpy.c
cbe1e41 
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
@suab321321 @jacobperron
Update rclpy/src/rclpy/_rclpy.c
b7a2230 
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
@suab321321 @jacobperron
Update rclpy/src/rclpy/_rclpy.c
df56b5d 
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
@suab321321 @jacobperron
Update rclpy/src/rclpy/_rclpy.c
2551816 
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
@suab321321 @jacobperron
Update rclpy/src/rclpy/_rclpy.c
511e306 
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
@suab321321 @jacobperron
Update rclpy/src/rclpy/_rclpy.c
6df38ee 
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
suab321321 and others added 7 commits December 10, 2019 11:12
@suab321321 @jacobperron
Update rclpy/src/rclpy/_rclpy.c
237f9c3 
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
@suab321321 @allenh1 @jacobperron
Update rclpy/src/rclpy/_rclpy.c
ad36ec6 
Co-Authored-By: Hunter L. Allen <hunterlallen@protonmail.com>
@suab321321 @allenh1 @jacobperron
Update rclpy/src/rclpy/_rclpy.c
65f6dd4 
Co-Authored-By: Hunter L. Allen <hunterlallen@protonmail.com>
@suab321321 @jacobperron
Update rclpy/src/rclpy/_rclpy.c
84c1338 
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
@suab321321 @jacobperron
Update rclpy/src/rclpy/_rclpy.c
51d4f27 
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
@suab321321 @jacobperron
Update rclpy/src/rclpy/_rclpy.c
8782eee 
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Fix indentation
261a2dc 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
jacobperron approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased these changes on master to get the latest fixes there for CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit 83dd5c3 into ros2:master Dec 10, 2019
@jacobperron
Copy link
Member

@suab321321 Thanks again for the improvement!

@suab321321
Copy link
Contributor Author

@allenh1 @jacobperron thank you for your guiding me sir.

@sloretz sloretz mentioned this pull request Jan 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allenh1 allenh1 allenh1 left review comments

@jacobperron jacobperron jacobperron approved these changes

Assignees

@jacobperron jacobperron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create custom exceptions in _rclpy.c
3 participants
@suab321321 @jacobperron @allenh1