Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated QoS functionality #431

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Remove deprecated QoS functionality #431

merged 1 commit into from
Sep 18, 2019

Conversation

jacobperron
Copy link
Member

Existing warnings are replaced with a new exception, InvalidQoSProfileException.

Resolves #430

@jacobperron
Remove deprecated QoS functionality
0c6c26b 
Existing warnings are replaced with a new exception, InvalidQoSProfileException.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron mentioned this pull request Sep 18, 2019
Merged
ivanpauno
ivanpauno approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (with green CI)

@jacobperron
Copy link
Member Author

jacobperron commented Sep 18, 2019 •
edited
Loading

@jacobperron jacobperron merged commit 1e10707 into master Sep 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/remove_deprecated_qos branch September 18, 2019 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated functionality post-Dashing
2 participants
@jacobperron @ivanpauno