Code

Rclpy wait for service#127

Code

Closed

sloretz wants to merge 49 commits intomasterros2/rclpy:masterfrom rclpy_wait_for_serviceros2/rclpy:rclpy_wait_for_serviceCopy head branch name to clipboard

+1,512-524

Commits

Commits on Oct 25, 2017

• Dirty: First proof of concept for wait_for_service implementation

  sloretz

  committed
  372c1a9

  Copy full SHA for 372c1a9

• Moved wait set code to its own class for code reuse

  sloretz

  committed
  817990a

  Copy full SHA for 817990a

• Added timeout_sec_to_nsec()

  sloretz

  committed
  9b91a62

  Copy full SHA for 9b91a62

• wait_for_service() implemented with timers

  sloretz

  committed
  371c917

  Copy full SHA for 371c917

• Added unit tests for timeout_sec_to_nsec()

  sloretz

  committed
  b17f497

  Copy full SHA for b17f497

• Added test for WaitSet class

  sloretz

  committed
  35898a6

  Copy full SHA for 35898a6

• Use negative timeouts to mean block forever

  sloretz

  committed
  5b1ca62

  Copy full SHA for 5b1ca62

• Double quotes to single quotes

  sloretz

  committed
  489bc0e

  Copy full SHA for 489bc0e

• Added wait_for_service() tests and fixed bugs it caught

  sloretz

  committed
  f854466

  Copy full SHA for f854466

• Eliminate blind exception warning

  sloretz

  committed
  9255e1f

  Copy full SHA for 9255e1f

• Reduce flakiness of test by increasing time to 0.1s

  sloretz

  committed
  f89a222

  Copy full SHA for f89a222

• Comment says negative timeouts block forever

  sloretz

  committed
  39ac231

  Copy full SHA for 39ac231

• Use :returns:

  sloretz

  committed
  3237ed8

  Copy full SHA for 3237ed8

• Move add_subscriptions()

  sloretz

  committed
  7acb2a6

  Copy full SHA for 7acb2a6

• arugments -> arguments

  sloretz

  committed
  4720d3f

  Copy full SHA for 4720d3f

• Daemon as keyword arg

  sloretz

  committed
  395934a

  Copy full SHA for 395934a

• Remove unnecessary namespace argument

  sloretz

  committed
  1c9a098

  Copy full SHA for 1c9a098

• Use S_TO_NS in test

  sloretz

  committed
  655425f

  Copy full SHA for 655425f

• More tests using S_TO_NS

  sloretz

  committed
  ccd93d8

  Copy full SHA for ccd93d8

• Use monotonic clock for testing timer time

  sloretz

  committed
  441bbb5

  Copy full SHA for 441bbb5

• Increased test timeout by 30 seconds

  sloretz

  committed
  8733c14

  Copy full SHA for 8733c14

• CheckExact -> IsValid

  sloretz

  committed
  3f26246

  Copy full SHA for 3f26246

• Fixed wait_set not clearing ready_pointers

  sloretz

  committed
  0a79f28

  Copy full SHA for 0a79f28

• Remove unnecessary namespace keyword arg

  sloretz

  committed
  65c545f

  Copy full SHA for 65c545f

• Non-blocking wait

  sloretz

  committed
  d81684c

  Copy full SHA for d81684c

• remove expression that always evaluates to True

  sloretz

  committed
  4bbc323

  Copy full SHA for 4bbc323

• Raise ValueError on invalid capsule

  sloretz

  committed
  99280ae

  Copy full SHA for 99280ae

• Simplified timeout_sec_to_nsec

  sloretz

  committed
  1d2beeb

  Copy full SHA for 1d2beeb

• Added 'WaitSet.destroy()' and made executor use it

  sloretz

  committed
  6980711

  Copy full SHA for 6980711

• GraphListener periodically checks if rclpy is shutdown

  sloretz

  committed
  c69858f

  Copy full SHA for c69858f

• Misc fixes after pycapsule names

  sloretz

  committed
  4cd2fb1

  Copy full SHA for 4cd2fb1

Commits on Oct 31, 2017

• Wait set class always clears entities before waiting

  sloretz

  committed
  0cf2aeb

  Copy full SHA for 0cf2aeb

• Remove underscore on import

  sloretz

  committed
  7843c5c

  Copy full SHA for 7843c5c

• Reformat timeout line

  sloretz

  committed
  ded618f

  Copy full SHA for ded618f

• Use () when raising exceptions

  sloretz

  committed
  e8f7fd6

  Copy full SHA for e8f7fd6

• Removed _ on imports

  sloretz

  committed
  149ad43

  Copy full SHA for 149ad43

Commits on Nov 1, 2017

• Executor optimizations

  Show description for dd86a13
  sloretz

  committed
  dd86a13

  Copy full SHA for dd86a13

• Fixed executor yielding entities to wrong node

  Show description for 6352e86
  sloretz

  committed
  6352e86

  Copy full SHA for 6352e86

• Use list() only where necessary

  sloretz

  committed
  0dbf8c7

  Copy full SHA for 0dbf8c7

• Docstring in imperitive mood

  sloretz

  committed
  1a2ce96

  Copy full SHA for 1a2ce96

• Executors reuse iterator

  sloretz

  committed
  7ee5ead

  Copy full SHA for 7ee5ead

Commits on Nov 2, 2017

• moved some wait_set code into C

  sloretz

  committed
  3628db4

  Copy full SHA for 3628db4

• Avoid another list comprehension

  sloretz

  committed
  b71d1c5

  Copy full SHA for b71d1c5

Commits on Nov 3, 2017

• Replaced WaitSet with C code in executor

  sloretz

  committed
  9d9113d

  Copy full SHA for 9d9113d

• Remove test code

  sloretz

  committed
  adfddf6

  Copy full SHA for adfddf6

Commits on Nov 8, 2017

• Use lists instead of set

  sloretz

  committed
  315db4e

  Copy full SHA for 315db4e

• Use locally defined function instead of member function

  sloretz

  committed
  e078c47

  Copy full SHA for e078c47

• Shorten code using macro

  sloretz

  committed
  5c92085

  Copy full SHA for 5c92085

Commits on Nov 9, 2017

• Move everything to new wait_set code

  sloretz

  committed
  70b8652

  Copy full SHA for 70b8652