-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add statistics for handle_loaned_message (backport #1927) #1933
Conversation
* Add statistics for handle_loaned_message Signed-off-by: Barry Xu <barry.xu@sony.com> (cherry picked from commit 5c68830) # Conflicts: # rclcpp/include/rclcpp/subscription.hpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Barry-Xu-2018 template is different from humble, can you address the conflict?
I will fix it. |
I created a commit to fix this merge conflicts. But I don't know to apply my fix. |
You should be able to make a PR that targets this PR. Then we can merge it into this PR before doing the final review and test. |
Get it. Thank you @clalancette |
Signed-off-by: Barry Xu <barry.xu@sony.com>
all green, i will go ahead to merge this. |
This is an automatic backport of pull request #1927 done by Mergify.
Cherry-pick of 5c68830 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com