Avoid implicit integer to double conversion

Signed-off-by: Andrea Sorbini <asorbini@rti.com>
ros2 · Mar 5, 2021 · 9de9593 · 9de9593
1 parent e11986b
commit 9de9593
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/rclcpp/test/rclcpp/executors/test_multi_threaded_executor.cpp b/rclcpp/test/rclcpp/executors/test_multi_threaded_executor.cpp
@@ -86,10 +86,13 @@ TEST_F(TestMultiThreadedExecutor, timer_over_take) {
         double diff = static_cast<double>(std::abs((now - last).nanoseconds())) / 1.0e9;
         last = now;
 
-        if (diff < PERIOD - TOLERANCE) {
+        double diff_exp =
+            static_cast<double>(PERIOD) - static_cast<double>(TOLERANCE);
+        if (diff < diff_exp) {
           executor.cancel();
-          ASSERT_GT(diff, PERIOD - TOLERANCE);
+          ASSERT_GT(diff, diff_exp);
         }
+
       }
     };