Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Python 3.5 specific logic #401

Merged
merged 3 commits into from
Apr 16, 2020
Merged

remove Python 3.5 specific logic #401

merged 3 commits into from
Apr 16, 2020

Conversation

dirk-thomas
Copy link
Member

Which was added in #85.

@dirk-thomas
remove Python 3.5 specific logic
e618355 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas self-assigned this Apr 15, 2020
jacobperron
jacobperron approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@dirk-thomas
remove unused import of os
b83b250 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas
Copy link
Member Author

dirk-thomas commented Apr 16, 2020 •
edited
Loading

CI builds with FastRTPS only:

  • Linux Build Status
  • macOS Build Status

Addressed the flake8 warnings in b83b250 and b28a12c. The other test failures seem to be present on master already.

@dirk-thomas
remove unused import of atexit
b28a12c 
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas merged commit 9af5c0e into master Apr 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/remove-py35-logic branch April 16, 2020 20:14
@rotu rotu mentioned this pull request Apr 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirk-thomas @jacobperron