-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace rmw_connext_cpp with rmw_connextdds #489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are still needed?
demos/pendulum_control/test/test_pendulum_demo.py.in
Lines 59 to 64 in ed0299d
if rmw_implementation.startswith('rmw_connext'): | |
# This output can be caused by a small QoS depth leading to samples being discarded. | |
# Since we are optimizing for performance with a depth of 1, we can ignore it. | |
filtered_prefixes.append( | |
'PRESWriterHistoryDriver_completeBeAsynchPub:!make_sample_reclaimable' | |
) |
demos/pendulum_control/test/test_pendulum_teleop.py.in
Lines 63 to 68 in ed0299d
if rmw_implementation.startswith('rmw_connext'): | |
# This output can be caused by a small QoS depth leading to samples being discarded. | |
# Since we are optimizing for performance with a depth of 1, we can ignore it. | |
filtered_prefixes.append( | |
'PRESWriterHistoryDriver_completeBeAsynchPub:!make_sample_reclaimable' | |
) |
@fujitatomoya I'm not sure, since I haven't tried removing them (and re-running the tests without them). I left them in to be on the safe side (since the tests are passing "as is"), but I can try removing them and seeing what happens. @ivanpauno if you want I can push a commit to also remove references to opensplice, but maybe those would be better tracked via a different PR? If so, I can do that too while I'm at it. EDIT: I realize now that creating a separate PR will only complicate things, so I'll just push a commit to this branch. |
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
bd1935c
to
e6e3ef2
Compare
PR build failed, but it seems to be doing that for all PRs. Given that this is just a change to the README files, I'm going to go ahead and merge. |
This PR replaces all references to
rmw_connext_cpp
withrmw_connextdds
.See rticommunity/rmw_connextdds #9 for a list of related PRs, and an overview of all the changes required to replace ros2/rmw_connext (
rmw_connext_cpp
) with rticommunity/rmw_connextdds in the ROS2 source tree.