Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable setting window size for MovingAverageStatistics #208

Open
tonynajjar opened this issue Jan 7, 2025 · 3 comments · May be fixed by #210
Open

Enable setting window size for MovingAverageStatistics #208

tonynajjar opened this issue Jan 7, 2025 · 3 comments · May be fixed by #210
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tonynajjar
Copy link

Description

The MovingAverageStatistics should allow passing a window_size for the calculation of the moving average

@tonynajjar tonynajjar added the enhancement New feature or request label Jan 7, 2025
@christophebedard christophebedard added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 7, 2025
@Tacha-S
Copy link

Tacha-S commented Feb 19, 2025

I also think this feature is essential.
In the first place, although it is called a moving average, it is actually calculating the overall average, which does not align with the class name.
Just to confirm, the original intention of the implementation was to have MovingAverageStatistics calculate a moving average, correct?

@Tacha-S
Copy link

Tacha-S commented Feb 19, 2025

Or was it simply intended to calculate an online average for the sequentially obtained data?

@christophebedard
Copy link
Member

Looking at the implementation, it looks like it was definitely intended to cover all the data, even though it mentions "moving average."

However, changing it to be able to consider a real window (i.e., only the last X values) makes sense to me. PRs are welcome.

@Tacha-S Tacha-S linked a pull request Feb 20, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants