Foxy backports #1220
Merged
Foxy backports #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a colcon.pkg file to gazebo_dev with gazebo's cmake project name "Gazebo" listed as a dependency to support building gazebo from source in a colcon workspace. * Add colcon.pkg files for other packages Copy colcon.pkg to gazebo_ros, gazebo_plugins, and gazebo_ros_control so that --merge-install won't be required. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
…1205) We are currently subscribing to the /gazebo/performance_metrics topic even if there are no subscribers to the ROS topic forwarding this data. This changes gazebo_ros_init to only subscribe to the gazebo topic if there are any subscribers to the corresponding ROS topic. While advertiser callbacks are used in ROS 1 but are not yet in ROS2, here we use polling in the GazeboRosInitPrivate::PublishSimTime callback to check for subscribers since it is called for each Gazebo time step. This also helps workaround the deadlock documented in #1175 and gazebosim/gazebo-classic#2902. This also adds a macro to reduce duplication of the version checking logic. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* Make p3d offset element names singular - <xyz_offsets> is renamed to <xyz_offset> - <rpy_offsets> is renamed to <rpy_offsets> The old names can still be used, but are deprecated. This is more consistent with the naming convention used in ROS 1 versions. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Add test for deprecated functionality Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Fix executor to avoid random exceptions when shutting down Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> * Add link to related issue in rclcpp Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
|
@osrf-jenkins run tests please |
scpeters
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting the following changes to Foxy: