Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROS 2] Bridge to republish PerformanceMetrics in ROS 2 #1147

Merged
merged 7 commits into from
Oct 1, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 11, 2020

This PR is related to this other PR gazebosim/gazebo-classic#2819 which adds a performanceMetrics message. Then this msg will be republish from the Gazebo transport layer to the ROS 2 network.

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Aug 27, 2020

The CI is not going to build until Gazebo 11 it's released with this new feature.

…and Gazebo 11.1

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding migration information for the new topic to this wiki page?

https://github.com/ros-simulation/gazebo_ros_pkgs/wiki/ROS-2-Migration:-ROS-Clocks-and-sim-time

@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 30, 2020

Added a new page https://github.com/ros-simulation/gazebo_ros_pkgs/wiki/ROS-2-Migration:-Performance-metrics

@ahcorde ahcorde requested a review from chapulina September 30, 2020 08:03
@chapulina chapulina merged commit b114403 into ros2 Oct 1, 2020
@chapulina chapulina deleted the ahcorde/ros2/performance_metrics branch October 1, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants