Release ros2 version for ROS2 iron

[Rayman]

On Ubuntu 2022.04 when you install ros-iron-pcl-ros you still get the ROS1 version (2.4.0). Can you release the ros2 branch on iron?

[Timple]

It's only the include <ros/ros.h> which is ros1. So a new bloom release which includes this fix: #410 should do it.

[Timple]

Actually, the ros2 branch seems to be a half-port.

For example this line: https://github.com/ros-perception/perception_pcl/blob/ros2/pcl_ros/include/pcl_ros/point_cloud.hpp#L155

sensor_msgs::PointCloud2

Should be

sensor_msgs::msg::PointCloud2

So I don't think this file has worked for anyone on ros2 yet.

[SteveMacenski]

This repo is not fully ported to ROS 2, this is true. Type masqerading was never fully implemented (mostly because masqerading didn't exist for a long time). You can see a number of things are commented out and not being compiled [1]

[1] https://github.com/ros-perception/perception_pcl/blob/ros2/pcl_ros/CMakeLists.txt

[mvieth]

There is a pull request which fixes the types on the ros2 branch: #425

[shu-beg]

Is there any update regarding the release of already ported features? I had a short look into perception_pcl-release and it seems as there was an attempt to release at least 2.4.1 but for humble / iron / rolling there is still only 2.4.0 available as debian? Anyways, as there are quite useful features available on ros2 branch compared to 2.4.1 (e.g. filters) I would really appreciate a new release.

[SteveMacenski]

Figuring it out now, I'm rolling back locally the ros2 branch to the last sync and branching off humble / iron and going to roll forward those commits that are API/ABI compatiable and then run a sync over those with the subset of ros2 changes that are appropriate. I'll also update Rolling.

Currently in progress.

[SteveMacenski]

My apologies, I'm not sure how this fell so far off my radar for so long

[Rayman]

@shu-beg ros/rosdistro#40476

[Rayman]

Last sync we caused a regression on the 2.5.1 release for iron. Can we try again next sync? The filter nodes are very useful to have.

[SteveMacenski]

Was that fixed in iron branch? I can run again if we're good to go again.

Sorry, I've had alot on my plate and some things have been intentionally dropped. I'm getting onto the right side of that pile of work this week hopefully :-) Open source maintainers' work is never done, but at some point I as a human need to be done 😆

[Rayman]

I think we need this PR: #447

So if you cherry pick that commit to iron you should be good to go.

For me personally I would like to see the whole rolling branch released on iron. A lot more code has been ported from ROS1 to ROS2. But I can imagine that would break ABI compatibility

[SteveMacenski]

ros/rosdistro#41386