Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added usuage of rqt_joint_trajectory_controller in documentation of e… #734

Merged
merged 7 commits into from
Mar 11, 2025
Merged

Added usuage of rqt_joint_trajectory_controller in documentation of e… #734

merged 7 commits into from
Mar 11, 2025

Conversation

AdityaPawar162
Copy link
Contributor

This commit adds documentation and implementation for Example 1 of the rqt_joint_trajectory_controller. It includes step-by-step instructions on setting up and using the controller.

@AdityaPawar162 AdityaPawar162 mentioned this pull request Mar 8, 2025
Closed
8 tasks
christophfroehlich
christophfroehlich requested changes Mar 9, 2025
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for this addition. I proposed a link to the already existing page, and fixed the syntax.

AdityaPawar162 and others added 4 commits March 10, 2025 16:29
@AdityaPawar162 @christophfroehlich
Update example_1/doc/userdoc.rst
cbf25e6 
Added the reference link for rqt_joint_trajectory_controller.

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
@AdityaPawar162 @christophfroehlich
Update example_1/doc/userdoc.rst
93a6e91 
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
@AdityaPawar162 @christophfroehlich
Update example_1/doc/userdoc.rst
44485cf 
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
@AdityaPawar162
Removed trailing whitespace
09e912c
@AdityaPawar162 AdityaPawar162 mentioned this pull request Mar 10, 2025
Merged
@AdityaPawar162
Copy link
Contributor Author

Hi @christophfroehlich,
I have made suggested changes and open a PR for rqt_joint_trajectory_controller.

christophfroehlich
christophfroehlich requested changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
The docs now looks fine. Please just add rqt_joint_trajectory_controller to the package.xml as exec-dependency.

christophfroehlich
christophfroehlich requested changes Mar 11, 2025
View reviewed changes
@christophfroehlich christophfroehlich merged commit 596674c into ros-controls:master Mar 11, 2025
13 checks passed
mergify bot pushed a commit that referenced this pull request Mar 11, 2025
@AdityaPawar162 @mergify
Added usuage of rqt_joint_trajectory_controller in documentation of e… (
1837f27 
#734)

(cherry picked from commit 596674c)
This was referenced Mar 11, 2025
Merged
Merged
christophfroehlich pushed a commit that referenced this pull request Mar 11, 2025
@mergify @AdityaPawar162
Added usuage of rqt_joint_trajectory_controller in documentation of e… (
eb8df71 
#734) (#738)

(cherry picked from commit 596674c)

Co-authored-by: Aditya Pawar <adityavpawar2003@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophfroehlich christophfroehlich christophfroehlich approved these changes

@aprotyas aprotyas Awaiting requested review from aprotyas

@destogl destogl Awaiting requested review from destogl

@fmauch fmauch Awaiting requested review from fmauch

@LukasMacha97 LukasMacha97 Awaiting requested review from LukasMacha97

@mcbed mcbed Awaiting requested review from mcbed

@Raivias Raivias Awaiting requested review from Raivias

Assignees
No one assigned
Labels
backport-humble
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdityaPawar162 @christophfroehlich