-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Transmissions] Make transmission interface work with new variants approach #1845
base: master
Are you sure you want to change the base?
[Transmissions] Make transmission interface work with new variants approach #1845
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1845 +/- ##
==========================================
- Coverage 89.59% 89.41% -0.18%
==========================================
Files 139 139
Lines 15222 15409 +187
Branches 1290 1298 +8
==========================================
+ Hits 13638 13778 +140
- Misses 1096 1139 +43
- Partials 488 492 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gcc still has some deprecation warnings
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The new changes to the handles, that the data exists inside the Handle itself will create problems with the old transmission_interface API and it is kinda dysfunctional with the new approach. This PR aims to solve the issue by migrating the transmission part to the new API and making it functional with the latest shared pointers approach.