-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RTPublisher] use NON_POLLING as default for the realtime pubisher #280
[RTPublisher] use NON_POLLING as default for the realtime pubisher #280
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #280 +/- ##
==========================================
- Coverage 72.25% 71.76% -0.50%
==========================================
Files 8 8
Lines 483 471 -12
Branches 77 74 -3
==========================================
- Hits 349 338 -11
+ Misses 87 86 -1
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup and even improving it. LGTM, but let's wait for some real-world tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thanks!
) * Remove the non_polling tests as they are redundant now * scope instead of calling unlock method * Use memory orders with atomic State * Change the turn_ to be aligned with the corresponding loop (cherry picked from commit 386282f) # Conflicts: # CMakeLists.txt
) * Remove the non_polling tests as they are redundant now * scope instead of calling unlock method * Use memory orders with atomic State * Change the turn_ to be aligned with the corresponding loop (cherry picked from commit 386282f) # Conflicts: # CMakeLists.txt
…ackport #280) (#282) * Remove the non_polling tests as they are redundant now * scope instead of calling unlock method * Use memory orders with atomic State * Change the turn_ to be aligned with the corresponding loop ----- Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com> Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Fixes: #212
As reported by @bijoua29