Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid calls to the API on CI and CRAN #100

Merged
merged 14 commits into from
Nov 9, 2021
Merged

Avoid calls to the API on CI and CRAN #100

merged 14 commits into from
Nov 9, 2021

Conversation

KevCaz
Copy link
Member

@KevCaz KevCaz commented Oct 25, 2020

In this PR

  1. Unit tests now use vcr to avoid direct calls to the web APIs (and avoid being archived repeatedly on CRAN):
    • cassettes are in tests/fixtures
    • add vcr in Suggests
  2. The vignette has been precomputed (again to avoid calls to web API).
  3. All examples are within the \donttest tag and the CI will ignore those examples (but one can easily run those locally).
  4. Travis and Appveyor have been dropped and replaced by GitHub Actions.
  5. get_collection() methods always return an object of class mgNetworksCollection (Principle of least astonishment), to that end get_network_by_id() gained an argument force_collection.

@codecov-io
Copy link

codecov-io commented Oct 25, 2020

Codecov Report

Merging #100 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files          12       12           
  Lines         375      375           
=======================================
  Hits          361      361           
  Misses         14       14           
Impacted Files Coverage Δ
R/zzz.R 96.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22bad46...df28382. Read the comment docs.

@KevCaz KevCaz changed the title 👷 use vcr for tests Avoid calls to the API on CI and CRAN Nov 9, 2021
@KevCaz KevCaz self-assigned this Nov 9, 2021
@KevCaz
Copy link
Member Author

KevCaz commented Nov 9, 2021

Ready to go.

@KevCaz KevCaz merged commit 394284d into master Nov 9, 2021
@KevCaz KevCaz deleted the usecassettes branch November 17, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants