Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sf from dependencies list #83

Closed
3 tasks done
KevCaz opened this issue Aug 28, 2019 · 2 comments
Closed
3 tasks done

Remove sf from dependencies list #83

KevCaz opened this issue Aug 28, 2019 · 2 comments
Assignees
@KevCaz
Labels
rOpenSci - review Adress reviewers comments

Comments

@KevCaz
Copy link
Member

KevCaz commented Aug 28, 2019 •
edited
Loading

As suggested by the reviewer ropensci/software-review#332 (comment) let's remove sf from the dependencies:

  • remove search_networks_sf()
  • remove associated tests
  • make an example in the vignette how to do this kind of sorting.
@KevCaz KevCaz added the rOpenSci - review Adress reviewers comments label Aug 28, 2019
@KevCaz KevCaz self-assigned this Aug 28, 2019
@SteveViss
Copy link
Member

Related to d5a00d5

SteveViss added a commit that referenced this issue Aug 28, 2019
@SteveViss
add utils in import - related to #83
989e84d
@SteveViss
Copy link
Member

SteveViss commented Aug 28, 2019 •
edited
Loading

I choose to leave the function search_network_sf(). If a sf object is passed to the function and the package is not installed, then the user will receive an error recommending to install it.

@SteveViss SteveViss mentioned this issue Sep 5, 2019
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KevCaz KevCaz

Labels
rOpenSci - review Adress reviewers comments
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SteveViss @KevCaz