Review changes #28
Review changes #28
Conversation
much more descriptive
this does not pass `lintr::lint_package()`
|
R/db-lib.R:64:12: style: Words within variable and function names should be separated by '_' rather than '.'. self$polyhedra.rds.file <- getPolyhedraRDSPath()
^~~~~~~~~~~~~~~~~~R/db-lib.R:65:12: style: Words within variable and function names should be separated by '_' rather than '.'. self$polyhedra.rds.file
^~~~~~~~~~~~~~~~~~R/db-lib.R:136:30: style: Words within variable and function names should be separated by '_' rather than '.'. save.on.change = FALSE) {
^~~~~~~~~~~~~~R/db-lib.R:141:47: style: Words within variable and function names should be separated by '_' rather than '.'. if (!overwrite & !is.null(prev.data) & !save.on.change){
^~~~~~~~~~~~~~R/db-lib.R:156:13: style: Words within variable and function names should be separated by '_' rather than '.'. if (save.on.change){
^~~~~~~~~~~~~~R/db-lib.R:165:47: style: Words within variable and function names should be separated by '_' rather than '.'. futile.logger::flog.info(paste(ifelse(save.on.change,
^~~~~~~~~~~~~~R/db-lib.R:185:38: style: Words within variable and function names should be separated by '_' rather than '.'. save.on.change = FALSE) {
^~~~~~~~~~~~~~R/db-lib.R:187:7: style: Words within variable and function names should be separated by '_' rather than '.'. home.dir.data <- getDataDir()
^~~~~~~~~~~~~R/db-lib.R:190:51: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedra.dir <- source.config$getBaseDir(home.dir.data)
^~~~~~~~~~~~~R/db-lib.R:191:58: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedra.files <- source.config$getPolyhedraFiles(home.dir.data)
^~~~~~~~~~~~~R/db-lib.R:220:37: style: Words within variable and function names should be separated by '_' rather than '.'. self$saveRDS(save.on.change = save.on.change)
^~~~~~~~~~~~~~R/db-lib.R:223:24: style: Words within variable and function names should be separated by '_' rather than '.'. saveRDS = function(save.on.change = TRUE){
^~~~~~~~~~~~~~R/db-lib.R:225:31: style: Words within variable and function names should be separated by '_' rather than '.'. if (self$ledger$dirty & save.on.change){
^~~~~~~~~~~~~~R/db-lib.R:228:45: style: Words within variable and function names should be separated by '_' rather than '.'. self$polyhedra.rds.file))
^~~~~~~~~~~~~~~~~~R/db-lib.R:229:35: style: Words within variable and function names should be separated by '_' rather than '.'. ret <- saveRDS(self, self$polyhedra.rds.file)
^~~~~~~~~~~~~~~~~~R/db-lib.R:238:22: style: Words within variable and function names should be separated by '_' rather than '.'. save.on.change = FALSE,
^~~~~~~~~~~~~~R/db-lib.R:243:9: style: Words within variable and function names should be separated by '_' rather than '.'. max.quant.retrieve <- 0
^~~~~~~~~~~~~~~~~~R/db-lib.R:246:9: style: Words within variable and function names should be separated by '_' rather than '.'. max.quant.retrieve <- max.quant
^~~~~~~~~~~~~~~~~~R/db-lib.R:250:53: style: Words within variable and function names should be separated by '_' rather than '.'. max.quant = max.quant.retrieve,
^~~~~~~~~~~~~~~~~~R/db-lib.R:258:7: style: Words within variable and function names should be separated by '_' rather than '.'. home.dir.data <- getDataDir()
^~~~~~~~~~~~~R/db-lib.R:263:13: style: Words within variable and function names should be separated by '_' rather than '.'. sample.2.cover <- sort(sample(1:n, size = max.quant))
^~~~~~~~~~~~~~R/db-lib.R:266:13: style: Words within variable and function names should be separated by '_' rather than '.'. sample.2.cover <- 1:n
^~~~~~~~~~~~~~R/db-lib.R:268:48: style: Words within variable and function names should be separated by '_' rather than '.'. filenames2scrape <- filenames2scrape[sample.2.cover, ]
^~~~~~~~~~~~~~R/db-lib.R:271:11: style: Words within variable and function names should be separated by '_' rather than '.'. current.filename.data <- filenames2scrape[r, ]
^~~~~~~~~~~~~~~~~~~~~R/db-lib.R:272:21: style: Words within variable and function names should be separated by '_' rather than '.'. source <- current.filename.data$source
^~~~~~~~~~~~~~~~~~~~~R/db-lib.R:274:53: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedra.dir <- source.config$getBaseDir(home.dir.data)
^~~~~~~~~~~~~R/db-lib.R:275:11: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedron.file.id <- current.filename.data$file.id
^~~~~~~~~~~~~~~~~~R/db-lib.R:275:33: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedron.file.id <- current.filename.data$file.id
^~~~~~~~~~~~~~~~~~~~~R/db-lib.R:276:30: style: Words within variable and function names should be separated by '_' rather than '.'. source.filename <- current.filename.data$source.filename
^~~~~~~~~~~~~~~~~~~~~R/db-lib.R:280:54: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedron.file.id = polyhedron.file.id,
^~~~~~~~~~~~~~~~~~R/db-lib.R:284:39: style: Words within variable and function names should be separated by '_' rather than '.'. self$saveRDS(save.on.change = save.on.change)
^~~~~~~~~~~~~~R/db-lib.R:292:23: style: Words within variable and function names should be separated by '_' rather than '.'. save.on.change = FALSE,
^~~~~~~~~~~~~~R/db-lib.R:293:23: style: Words within variable and function names should be separated by '_' rather than '.'. skip.still.queued = FALSE){
^~~~~~~~~~~~~~~~~R/db-lib.R:295:35: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedron.file.id, source.filename){
^~~~~~~~~~~~~~~~~~R/db-lib.R:303:34: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedron.file.id = polyhedron.file.id,
^~~~~~~~~~~~~~~~~~R/db-lib.R:310:49: style: Words within variable and function names should be separated by '_' rather than '.'. save.on.change = save.on.change)
^~~~~~~~~~~~~~R/db-lib.R:331:9: style: Words within variable and function names should be separated by '_' rather than '.'. max.quant.time <- self$ledger$getSizeToTimeScrape(sources = sources,
^~~~~~~~~~~~~~R/db-lib.R:335:9: style: Words within variable and function names should be separated by '_' rather than '.'. max.quant.time <- 0
^~~~~~~~~~~~~~R/db-lib.R:337:27: style: Words within variable and function names should be separated by '_' rather than '.'. if (max.quant > 0 & max.quant.time > 0){
^~~~~~~~~~~~~~R/db-lib.R:338:9: style: Words within variable and function names should be separated by '_' rather than '.'. max.quant.scrape <- min(max.quant, max.quant.time)
^~~~~~~~~~~~~~~~R/db-lib.R:338:44: style: Words within variable and function names should be separated by '_' rather than '.'. max.quant.scrape <- min(max.quant, max.quant.time)
^~~~~~~~~~~~~~R/db-lib.R:342:9: style: Words within variable and function names should be separated by '_' rather than '.'. max.quant.scrape <- max(max.quant,
^~~~~~~~~~~~~~~~R/db-lib.R:343:33: style: Words within variable and function names should be separated by '_' rather than '.'. max.quant.time)
^~~~~~~~~~~~~~R/db-lib.R:352:41: style: Words within variable and function names should be separated by '_' rather than '.'. max.quant.time,
^~~~~~~~~~~~~~R/db-lib.R:354:41: style: Words within variable and function names should be separated by '_' rather than '.'. max.quant.scrape))
^~~~~~~~~~~~~~~~R/db-lib.R:358:35: style: Words within variable and function names should be separated by '_' rather than '.'. max.quant = max.quant.scrape,
^~~~~~~~~~~~~~~~R/db-lib.R:359:35: style: Words within variable and function names should be separated by '_' rather than '.'. save.on.change = save.on.change)
^~~~~~~~~~~~~~R/db-lib.R:360:11: style: Words within variable and function names should be separated by '_' rather than '.'. if (skip.still.queued){
^~~~~~~~~~~~~~~~~R/db-lib.R:374:41: style: Words within variable and function names should be separated by '_' rather than '.'. self$saveRDS(save.on.change = save.on.change)
^~~~~~~~~~~~~~R/db-lib.R:382:28: style: Words within variable and function names should be separated by '_' rather than '.'. if (file.exists(self$polyhedra.rds.file)) {
^~~~~~~~~~~~~~~~~~R/db-lib.R:383:9: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedra.db.saved <- readRDS(self$polyhedra.rds.file)
^~~~~~~~~~~~~~~~~~R/db-lib.R:383:44: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedra.db.saved <- readRDS(self$polyhedra.rds.file)
^~~~~~~~~~~~~~~~~~R/db-lib.R:384:39: style: Words within variable and function names should be separated by '_' rather than '.'. if (!isCompatiblePolyhedraRDS(polyhedra.db.saved)){
^~~~~~~~~~~~~~~~~~R/db-lib.R:395:33: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedron.file.id,
^~~~~~~~~~~~~~~~~~R/db-lib.R:401:34: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedron.file.id = polyhedron.file.id,
^~~~~~~~~~~~~~~~~~R/db-lib.R:421:20: style: Variable and function names should not use underscores. res <- expect_true(self$existsPolyhedron(source = source,
^~~~~~~~~~~R/db-lib.R:426:13: style: Variable and function names should not use underscores. expect_equal(scraped.polyhedron, db.polyhedron)
^~~~~~~~~~~~R/db-lib.R:457:28: style: Words within variable and function names should be separated by '_' rather than '.'. if (file.exists(self$polyhedra.rds.file)) {
^~~~~~~~~~~~~~~~~~R/db-lib.R:458:9: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedra.db.saved <- readRDS(self$polyhedra.rds.file)
^~~~~~~~~~~~~~~~~~R/db-lib.R:458:44: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedra.db.saved <- readRDS(self$polyhedra.rds.file)
^~~~~~~~~~~~~~~~~~R/db-lib.R:459:39: style: Words within variable and function names should be separated by '_' rather than '.'. if (!isCompatiblePolyhedraRDS(polyhedra.db.saved)){
^~~~~~~~~~~~~~~~~~R/db-lib.R:468:7: style: Words within variable and function names should be separated by '_' rather than '.'. test.task.gen.function <- function(polyhedra.dir, source.config,
^~~~~~~~~~~~~~~~~~~~~~R/db-lib.R:469:42: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedron.file.id, source.filename){
^~~~~~~~~~~~~~~~~~R/db-lib.R:472:30: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedron.ledger <- polyhedra.db.saved$ledger$
^~~~~~~~~~~~~~~~~~R/db-lib.R:473:14: style: Words within variable and function names should be separated by '_' rather than '.'. df[polyhedra.db.saved$ledger$getIdFilename(source, source.filename), ]
^~~~~~~~~~~~~~~~~~R/db-lib.R:476:50: style: Words within variable and function names should be separated by '_' rather than '.'. task <- TestTaskClass$new(polyhedra.db = polyhedra.db.saved,
^~~~~~~~~~~~~~~~~~R/db-lib.R:480:56: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedron.file.id = polyhedron.file.id,
^~~~~~~~~~~~~~~~~~R/db-lib.R:486:43: style: Words within variable and function names should be separated by '_' rather than '.'. covering.code = test.task.gen.function,
^~~~~~~~~~~~~~~~~~~~~~R/db-lib.R:497:42: style: Words within variable and function names should be separated by '_' rather than '.'. save.on.change = FALSE){
^~~~~~~~~~~~~~R/db-lib.R:502:55: style: Words within variable and function names should be separated by '_' rather than '.'. save.on.change = save.on.change)
^~~~~~~~~~~~~~R/env-lib.R:74:5: style: Words within variable and function names should be separated by '_' rather than '.'. .data.env <- "PACKAGE"
^~~~~~~~~R/env-lib.R:76:5: style: Words within variable and function names should be separated by '_' rather than '.'. .data.env <- readLines(environment.filepath)[1]
^~~~~~~~~R/env-lib.R:79:37: style: Words within variable and function names should be separated by '_' rather than '.'. setUserEnvir(".data.env", value = .data.env)
^~~~~~~~~R/env-lib.R:80:3: style: Words within variable and function names should be separated by '_' rather than '.'. .data.env
^~~~~~~~~R/env-lib.R:122:5: style: Words within variable and function names should be separated by '_' rather than '.'. .data.env <- env
^~~~~~~~~R/env-lib.R:128:11: style: Words within variable and function names should be separated by '_' rather than '.'. write(.data.env, getEnvironmentFilepath())
^~~~~~~~~R/env-lib.R:131:37: style: Words within variable and function names should be separated by '_' rather than '.'. setUserEnvir(".data.env", value = .data.env)
^~~~~~~~~R/env-lib.R:132:3: style: Words within variable and function names should be separated by '_' rather than '.'. .data.env
^~~~~~~~~R/env-lib.R:154:33: style: Variable and function names should not use underscores. getPolyhedraRDSPath <- function(polyhedra_rds_filename = "polyhedra.RDS") {
^~~~~~~~~~~~~~~~~~~~~~R/env-lib.R:155:27: style: Variable and function names should not use underscores. file.path(getDataDir(), polyhedra_rds_filename)
^~~~~~~~~~~~~~~~~~~~~~R/env-lib.R:205:3: style: Words within variable and function names should be separated by '_' rather than '.'. .data.env <- getDataEnv()
^~~~~~~~~R/env-lib.R:207:7: style: Words within variable and function names should be separated by '_' rather than '.'. if (.data.env == "HOME"){
^~~~~~~~~R/ledger-lib.R:92:8: style: Words within variable and function names should be separated by '_' rather than '.'. row.preloaded.t2s <- which(self$preloaded.data$source == source &
^~~~~~~~~~~~~~~~~R/ledger-lib.R:94:19: style: Words within variable and function names should be separated by '_' rather than '.'. if (length(row.preloaded.t2s) == 1){
^~~~~~~~~~~~~~~~~R/ledger-lib.R:95:48: style: Words within variable and function names should be separated by '_' rather than '.'. preloaded.data <- self$preloaded.data[row.preloaded.t2s, ]
^~~~~~~~~~~~~~~~~R/ledger-lib.R:149:6: style: Words within variable and function names should be separated by '_' rather than '.'. scraped.name.lower <- ""
^~~~~~~~~~~~~~~~~~R/ledger-lib.R:178:10: style: Words within variable and function names should be separated by '_' rather than '.'. fields.numeric.update <- c("time.scraped")
^~~~~~~~~~~~~~~~~~~~~R/ledger-lib.R:179:10: style: Words within variable and function names should be separated by '_' rather than '.'. values.numeric.update <- c(time.scraped)
^~~~~~~~~~~~~~~~~~~~~R/ledger-lib.R:192:12: style: Words within variable and function names should be separated by '_' rather than '.'. scraped.name.lower <- tolower(scraped.name)
^~~~~~~~~~~~~~~~~~R/ledger-lib.R:193:12: style: Words within variable and function names should be separated by '_' rather than '.'. existing.polyhedron.name.rows <- which(self$df$source == source &
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~R/ledger-lib.R:194:61: style: Words within variable and function names should be separated by '_' rather than '.'. self$df$scraped.name == scraped.name.lower)
^~~~~~~~~~~~~~~~~~R/ledger-lib.R:195:23: style: Words within variable and function names should be separated by '_' rather than '.'. if (length(existing.polyhedron.name.rows) > 0){
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~R/ledger-lib.R:196:53: style: Words within variable and function names should be separated by '_' rather than '.'. error <- paste(error, "Scraped name ", scraped.name.lower,
^~~~~~~~~~~~~~~~~~R/ledger-lib.R:198:35: style: Words within variable and function names should be separated by '_' rather than '.'. paste(existing.polyhedron.name.rows,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~R/ledger-lib.R:203:18: style: Words within variable and function names should be separated by '_' rather than '.'. if (scraped.name.lower != tolower(preloaded.name)){
^~~~~~~~~~~~~~~~~~R/ledger-lib.R:220:31: style: Words within variable and function names should be separated by '_' rather than '.'. scraped.name.lower,
^~~~~~~~~~~~~~~~~~R/ledger-lib.R:223:12: style: Words within variable and function names should be separated by '_' rather than '.'. fields.numeric.update <- c(fields.numeric.update,
^~~~~~~~~~~~~~~~~~~~~R/ledger-lib.R:223:39: style: Words within variable and function names should be separated by '_' rather than '.'. fields.numeric.update <- c(fields.numeric.update,
^~~~~~~~~~~~~~~~~~~~~R/ledger-lib.R:226:12: style: Words within variable and function names should be separated by '_' rather than '.'. values.numeric.update <- c(values.numeric.update,
^~~~~~~~~~~~~~~~~~~~~R/ledger-lib.R:226:39: style: Words within variable and function names should be separated by '_' rather than '.'. values.numeric.update <- c(values.numeric.update,
^~~~~~~~~~~~~~~~~~~~~R/ledger-lib.R:230:32: style: Words within variable and function names should be separated by '_' rather than '.'. self$df[retrieved.id, fields.numeric.update] <-
^~~~~~~~~~~~~~~~~~~~~R/ledger-lib.R:231:12: style: Words within variable and function names should be separated by '_' rather than '.'. values.numeric.update
^~~~~~~~~~~~~~~~~~~~~R/ledger-lib.R:245:38: style: Words within variable and function names should be separated by '_' rather than '.'. scraped.name.lower,
^~~~~~~~~~~~~~~~~~R/ledger-lib.R:318:37: style: Words within variable and function names should be separated by '_' rather than '.'. write.csv(preloaded.data, self$preloaded.data.filename,
^~~~~~~~~~~~~~~~~~~~~~~R/ledger-lib.R:323:11: style: Words within variable and function names should be separated by '_' rather than '.'. self$preloaded.data.filename <- getPreloadedDataFilename()
^~~~~~~~~~~~~~~~~~~~~~~R/ledger-lib.R:324:50: style: Words within variable and function names should be separated by '_' rather than '.'. self$preloaded.data <- utils::read.csv(self$preloaded.data.filename)
^~~~~~~~~~~~~~~~~~~~~~~R/ledger-lib.R:328:6: style: Words within variable and function names should be separated by '_' rather than '.'. pre.comp.source <- self$preloaded.data[self$preloaded.data$source %in%
^~~~~~~~~~~~~~~R/ledger-lib.R:330:6: style: Words within variable and function names should be separated by '_' rather than '.'. pre.comp.source <- pre.comp.source[order(pre.comp.source$vertices,
^~~~~~~~~~~~~~~R/ledger-lib.R:330:25: style: Words within variable and function names should be separated by '_' rather than '.'. pre.comp.source <- pre.comp.source[order(pre.comp.source$vertices,
^~~~~~~~~~~~~~~R/ledger-lib.R:330:47: style: Words within variable and function names should be separated by '_' rather than '.'. pre.comp.source <- pre.comp.source[order(pre.comp.source$vertices,
^~~~~~~~~~~~~~~R/ledger-lib.R:331:47: style: Words within variable and function names should be separated by '_' rather than '.'. pre.comp.source$faces,
^~~~~~~~~~~~~~~R/ledger-lib.R:332:47: style: Words within variable and function names should be separated by '_' rather than '.'. pre.comp.source$source,
^~~~~~~~~~~~~~~R/ledger-lib.R:333:47: style: Words within variable and function names should be separated by '_' rather than '.'. pre.comp.source$filename), ]
^~~~~~~~~~~~~~~R/ledger-lib.R:335:6: style: Words within variable and function names should be separated by '_' rather than '.'. pre.comp.source$cummsum <- cumsum(pre.comp.source$time2scrape)
^~~~~~~~~~~~~~~R/ledger-lib.R:335:40: style: Words within variable and function names should be separated by '_' rather than '.'. pre.comp.source$cummsum <- cumsum(pre.comp.source$time2scrape)
^~~~~~~~~~~~~~~R/ledger-lib.R:336:19: style: Words within variable and function names should be separated by '_' rather than '.'. length(which(pre.comp.source$cummsum < time2scrape))
^~~~~~~~~~~~~~~R/ledger-lib.R:363:38: style: Words within variable and function names should be separated by '_' rather than '.'. order.by.vertices.faces = FALSE){
^~~~~~~~~~~~~~~~~~~~~~~R/ledger-lib.R:382:56: style: Words within variable and function names should be separated by '_' rather than '.'. order.by.vertices.faces = order.by.vertices.faces)
^~~~~~~~~~~~~~~~~~~~~~~R/ledger-lib.R:387:34: style: Words within variable and function names should be separated by '_' rather than '.'. order.by.vertices.faces = FALSE){
^~~~~~~~~~~~~~~~~~~~~~~R/ledger-lib.R:398:12: style: Words within variable and function names should be separated by '_' rather than '.'. if (order.by.vertices.faces){
^~~~~~~~~~~~~~~~~~~~~~~R/package-lib.R:8:38: style: Variable and function names should not use underscores. getPreloadedDataFilename <- function(polyhedra_preloaded_data =
^~~~~~~~~~~~~~~~~~~~~~~~R/package-lib.R:10:27: style: Variable and function names should not use underscores. file.path(getDataDir(), polyhedra_preloaded_data)
^~~~~~~~~~~~~~~~~~~~~~~~R/package-lib.R:23:3: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedra.rds.file <- getPolyhedraRDSPath()
^~~~~~~~~~~~~~~~~~R/package-lib.R:26:19: style: Words within variable and function names should be separated by '_' rather than '.'. if (file.exists(polyhedra.rds.file)) {
^~~~~~~~~~~~~~~~~~R/package-lib.R:27:36: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedra.candidate <- readRDS(polyhedra.rds.file)
^~~~~~~~~~~~~~~~~~R/package-lib.R:38:3: style: Words within variable and function names should be separated by '_' rather than '.'. .available.sources <- getPackageEnvir(".available.sources")
^~~~~~~~~~~~~~~~~~R/package-lib.R:39:3: style: Words within variable and function names should be separated by '_' rather than '.'. .available.scrapping.conf <- getPackageEnvir(".available.scrapping.conf")
^~~~~~~~~~~~~~~~~~~~~~~~~R/package-lib.R:44:35: style: Words within variable and function names should be separated by '_' rather than '.'. scrapePolyhedra(scrape.config = .available.scrapping.conf[["pkg-minimal"]],
^~~~~~~~~~~~~~~~~~~~~~~~~R/package-lib.R:46:36: style: Words within variable and function names should be separated by '_' rather than '.'. sources.config = .available.sources)
^~~~~~~~~~~~~~~~~~R/package-lib.R:83:9: style: Words within variable and function names should be separated by '_' rather than '.'. tmp.db.path <- list.files(path = td, pattern = "qbotics*")[1]
^~~~~~~~~~~R/package-lib.R:84:9: style: Words within variable and function names should be separated by '_' rather than '.'. files.to.copy <- list.files(file.path(td, tmp.db.path))
^~~~~~~~~~~~~R/package-lib.R:84:51: style: Words within variable and function names should be separated by '_' rather than '.'. files.to.copy <- list.files(file.path(td, tmp.db.path))
^~~~~~~~~~~R/package-lib.R:86:40: style: Words within variable and function names should be separated by '_' rather than '.'. file.copy(from = file.path(td, tmp.db.path, files.to.copy),
^~~~~~~~~~~R/package-lib.R:86:53: style: Words within variable and function names should be separated by '_' rather than '.'. file.copy(from = file.path(td, tmp.db.path, files.to.copy),
^~~~~~~~~~~~~R/package-lib.R:89:30: style: Words within variable and function names should be separated by '_' rather than '.'. unlink(file.path(td, tmp.db.path), recursive = TRUE)
^~~~~~~~~~~R/package-lib.R:111:3: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedra.ledger.scraped <-
^~~~~~~~~~~~~~~~~~~~~~~~R/package-lib.R:117:3: style: Words within variable and function names should be separated by '_' rather than '.'. .available.sources <- getPackageEnvir(".available.sources")
^~~~~~~~~~~~~~~~~~R/package-lib.R:118:24: style: Words within variable and function names should be separated by '_' rather than '.'. for (source in names(.available.sources)){
^~~~~~~~~~~~~~~~~~R/package-lib.R:119:22: style: Words within variable and function names should be separated by '_' rather than '.'. source.config <- .available.sources[[source]]
^~~~~~~~~~~~~~~~~~R/package-lib.R:120:5: style: Words within variable and function names should be separated by '_' rather than '.'. dest.folder.source <- source.config$getBaseDir(dest.folder)
^~~~~~~~~~~~~~~~~~R/package-lib.R:121:21: style: Words within variable and function names should be separated by '_' rather than '.'. if (file.exists(dest.folder.source)){
^~~~~~~~~~~~~~~~~~R/package-lib.R:127:16: style: Words within variable and function names should be separated by '_' rather than '.'. dest.folder.source, " Call ",
^~~~~~~~~~~~~~~~~~R/package-lib.R:131:24: style: Words within variable and function names should be separated by '_' rather than '.'. for (source in names(.available.sources)){
^~~~~~~~~~~~~~~~~~R/package-lib.R:132:22: style: Words within variable and function names should be separated by '_' rather than '.'. source.config <- .available.sources[[source]]
^~~~~~~~~~~~~~~~~~R/package-lib.R:133:5: style: Words within variable and function names should be separated by '_' rather than '.'. dest.folder.source <- source.config$getBaseDir(dest.folder)
^~~~~~~~~~~~~~~~~~R/package-lib.R:134:21: style: Words within variable and function names should be separated by '_' rather than '.'. if (file.exists(dest.folder.source)){
^~~~~~~~~~~~~~~~~~R/package-lib.R:135:14: style: Words within variable and function names should be separated by '_' rather than '.'. unlink(dest.folder.source, recursive = TRUE)
^~~~~~~~~~~~~~~~~~R/package-lib.R:137:16: style: Words within variable and function names should be separated by '_' rather than '.'. dir.create(dest.folder.source, showWarnings = FALSE, recursive = TRUE)
^~~~~~~~~~~~~~~~~~R/package-lib.R:148:26: style: Words within variable and function names should be separated by '_' rather than '.'. for (i in seq_len(nrow(polyhedra.ledger.scraped))){
^~~~~~~~~~~~~~~~~~~~~~~~R/package-lib.R:149:27: style: Words within variable and function names should be separated by '_' rather than '.'. current.polyhedron <- polyhedra.ledger.scraped[i, ]
^~~~~~~~~~~~~~~~~~~~~~~~R/package-lib.R:150:22: style: Words within variable and function names should be separated by '_' rather than '.'. source.config <- .available.sources[[current.polyhedron$source]]
^~~~~~~~~~~~~~~~~~R/package-lib.R:151:5: style: Words within variable and function names should be separated by '_' rather than '.'. dest.folder.source <- source.config$getBaseDir(dest.folder)
^~~~~~~~~~~~~~~~~~R/package-lib.R:154:19: style: Words within variable and function names should be separated by '_' rather than '.'. dest.folder.source)){
^~~~~~~~~~~~~~~~~~R/package-lib.R:191:27: style: Words within variable and function names should be separated by '_' rather than '.'. getBaseDir = function(home.dir.data) {
^~~~~~~~~~~~~R/package-lib.R:192:17: style: Words within variable and function names should be separated by '_' rather than '.'. file.path(home.dir.data, "sources", self$base.dir)
^~~~~~~~~~~~~R/package-lib.R:194:34: style: Words within variable and function names should be separated by '_' rather than '.'. getPolyhedraFiles = function(home.dir.data){
^~~~~~~~~~~~~R/package-lib.R:223:34: style: Words within variable and function names should be separated by '_' rather than '.'. getPolyhedraFiles = function(home.dir.data){
^~~~~~~~~~~~~R/package-lib.R:225:42: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedra.dir <- self$getBaseDir(home.dir.data)
^~~~~~~~~~~~~R/package-lib.R:231:23: style: Words within variable and function names should be separated by '_' rather than '.'. scrape = function(polyhedron.file.id, source.filename){
^~~~~~~~~~~~~~~~~~R/package-lib.R:232:7: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedra.netlib.lines <- readLines(source.filename)
^~~~~~~~~~~~~~~~~~~~~~R/package-lib.R:233:7: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedron.file.id <- source.filename
^~~~~~~~~~~~~~~~~~R/package-lib.R:234:7: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedron.file.id <- strsplit(polyhedron.file.id, split = "/")[[1]]
^~~~~~~~~~~~~~~~~~R/package-lib.R:234:38: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedron.file.id <- strsplit(polyhedron.file.id, split = "/")[[1]]
^~~~~~~~~~~~~~~~~~R/package-lib.R:235:7: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedron.file.id <- polyhedron.file.id[length(polyhedron.file.id)]
^~~~~~~~~~~~~~~~~~R/package-lib.R:235:29: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedron.file.id <- polyhedron.file.id[length(polyhedron.file.id)]
^~~~~~~~~~~~~~~~~~R/package-lib.R:235:55: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedron.file.id <- polyhedron.file.id[length(polyhedron.file.id)]
^~~~~~~~~~~~~~~~~~R/package-lib.R:236:60: style: Words within variable and function names should be separated by '_' rather than '.'. current.polyhedron <- Polyhedron.class$new(file.id = polyhedron.file.id)
^~~~~~~~~~~~~~~~~~R/package-lib.R:237:57: style: Words within variable and function names should be separated by '_' rather than '.'. current.polyhedron$scrapeNetlib(netlib.p3.lines = polyhedra.netlib.lines)
^~~~~~~~~~~~~~~~~~~~~~R/package-lib.R:269:34: style: Words within variable and function names should be separated by '_' rather than '.'. getPolyhedraFiles = function(home.dir.data){
^~~~~~~~~~~~~R/package-lib.R:276:42: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedra.dir <- self$getBaseDir(home.dir.data)
^~~~~~~~~~~~~R/package-lib.R:281:23: style: Words within variable and function names should be separated by '_' rather than '.'. scrape = function(polyhedron.file.id, source.filename){
^~~~~~~~~~~~~~~~~~R/package-lib.R:282:7: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedra.dmccoey.lines <- readLines(source.filename)
^~~~~~~~~~~~~~~~~~~~~~~R/package-lib.R:283:60: style: Words within variable and function names should be separated by '_' rather than '.'. current.polyhedron <- Polyhedron.class$new(file.id = polyhedron.file.id)
^~~~~~~~~~~~~~~~~~R/package-lib.R:285:42: style: Words within variable and function names should be separated by '_' rather than '.'. polyhedra.dmccoey.lines)
^~~~~~~~~~~~~~~~~~~~~~~R/package-lib.R:326:38: style: Words within variable and function names should be separated by '_' rather than '.'. isCompatiblePolyhedraRDS <- function(.polyhedra.candidate =
^~~~~~~~~~~~~~~~~~~~R/package-lib.R:329:23: style: Words within variable and function names should be separated by '_' rather than '.'. file.class <- class(.polyhedra.candidate)
^~~~~~~~~~~~~~~~~~~~R/package-lib.R:337:21: style: Words within variable and function names should be separated by '_' rather than '.'. compatible <- .polyhedra.candidate$getVersion() == db.version
^~~~~~~~~~~~~~~~~~~~R/package-lib.R:345:22: style: Words within variable and function names should be separated by '_' rather than '.'. .polyhedra.candidate$getVersion(),
^~~~~~~~~~~~~~~~~~~~R/package-lib.R:388:3: style: Words within variable and function names should be separated by '_' rather than '.'. .package.db <- getPackageEnvir(".package.db")
^~~~~~~~~~~R/package-lib.R:389:10: style: Words within variable and function names should be separated by '_' rather than '.'. ret <- .package.db[[getPackageVersion()]]
^~~~~~~~~~~R/polyhedra-lib.R:93:32: style: Words within variable and function names should be separated by '_' rather than '.'. initialize = function(file.id, netlib.p3.lines) {
^~~~~~~~~~~~~~~R/polyhedra-lib.R:95:10: style: Words within variable and function names should be separated by '_' rather than '.'. self$netlib.p3.lines <- netlib.p3.lines
^~~~~~~~~~~~~~~R/polyhedra-lib.R:95:29: style: Words within variable and function names should be separated by '_' rather than '.'. self$netlib.p3.lines <- netlib.p3.lines
^~~~~~~~~~~~~~~R/polyhedra-lib.R:100:28: style: Words within variable and function names should be separated by '_' rather than '.'. observer.label <- self$netlib.p3.lines[self$labels.rows[label.number]]
^~~~~~~~~~~~~~~R/polyhedra-lib.R:108:5: style: Words within variable and function names should be separated by '_' rather than '.'. first.data.row <- self$labels.rows[label.number]
^~~~~~~~~~~~~~R/polyhedra-lib.R:109:5: style: Words within variable and function names should be separated by '_' rather than '.'. last.data.row <- self$labels.rows[label.number + 1]
^~~~~~~~~~~~~R/polyhedra-lib.R:111:9: style: Words within variable and function names should be separated by '_' rather than '.'. if (first.data.row > last.data.row) {
^~~~~~~~~~~~~~R/polyhedra-lib.R:111:26: style: Words within variable and function names should be separated by '_' rather than '.'. if (first.data.row > last.data.row) {
^~~~~~~~~~~~~R/polyhedra-lib.R:114:9: style: Words within variable and function names should be separated by '_' rather than '.'. first.data.row, last.data.row))
^~~~~~~~~~~~~~R/polyhedra-lib.R:114:25: style: Words within variable and function names should be separated by '_' rather than '.'. first.data.row, last.data.row))
^~~~~~~~~~~~~R/polyhedra-lib.R:116:18: style: Words within variable and function names should be separated by '_' rather than '.'. ret <- c( (first.data.row + 1): (last.data.row - 1))
^~~~~~~~~~~~~~R/polyhedra-lib.R:116:40: style: Words within variable and function names should be separated by '_' rather than '.'. ret <- c( (first.data.row + 1): (last.data.row - 1))
^~~~~~~~~~~~~R/polyhedra-lib.R:121:10: style: Words within variable and function names should be separated by '_' rather than '.'. self$netlib.p3.lines[self$labels.rows]
^~~~~~~~~~~~~~~R/polyhedra-lib.R:144:5: style: Words within variable and function names should be separated by '_' rather than '.'. open.bracket.pos <- which(strsplit(x, "")[[1]] == "[")
^~~~~~~~~~~~~~~~R/polyhedra-lib.R:146:16: style: Words within variable and function names should be separated by '_' rather than '.'. if (length(open.bracket.pos) > 0) {
^~~~~~~~~~~~~~~~R/polyhedra-lib.R:147:29: style: Words within variable and function names should be separated by '_' rather than '.'. ret <- substr(x, 1, open.bracket.pos - 1)
^~~~~~~~~~~~~~~~ |
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
=======================================
Coverage 76.94% 76.94%
=======================================
Files 9 9
Lines 1579 1579
=======================================
Hits 1215 1215
Misses 364 364
Continue to review full report at Codecov.
|
From review in ropensci/software-review#157