Skip to content
This repository was archived by the owner on Mar 30, 2023. It is now read-only.

Possibly change interface #17

Closed
sckott opened this issue Jun 15, 2016 · 1 comment · Fixed by #19
Closed

Possibly change interface #17

sckott opened this issue Jun 15, 2016 · 1 comment · Fixed by #19
Assignees
Milestone

Comments

@sckott
Copy link
Contributor

sckott commented Jun 15, 2016

via r-spatial/sf#12

e.g., do

list(Point = c(116.4, 52.2))

instead of the current

list('type' = 'Point', 'coordinates' = c(116.4, 45.2))

it's still early days in the pkg, so not too bad to change if that's a better UI

@sckott
Copy link
Contributor Author

sckott commented Jun 15, 2016

it might make most sense to accept either format, with or without type as an element in the list. and bonus b/c that doesn't break the package API

@sckott sckott modified the milestone: v0.2 Sep 2, 2016
@sckott sckott self-assigned this Sep 2, 2016
sckott added a commit that referenced this issue Mar 14, 2017
both geojson2wkt fxns now expect the new format well go with for geojson as a list
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant