Bump Ansible version_tested_max to 2.4.3.0 #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix `replace_item_with_key()` custom output method to handle tasks that use `with_dict` and `no_log`. Prevents errors such as: [WARNING]: Failure using method (v2_runner_item_on_skipped) in callback plugin (<ansible.plugins.callback.output.CallbackModule object at 0x7f9cd2039150>): 'item'
swalkinshaw
approved these changes
Feb 1, 2018
primozcigler
added a commit
to proteusthemes/pt-ops
that referenced
this pull request
Mar 13, 2018
* trellis/master: Ensure Diffie-Hellman group is generated for Let's Encrypt (roots#964) Fix raw_vars feature to properly handle int values (roots#959) Update Ansible default plugin paths in config files (roots#958) Add Nginx ssl.no-default.conf to drop requests for unknown hosts (roots#888) Disable memcached UDP support by default Git: Ignore `vagrant.local.yml` Add sponsors [ci skip] Set Vagrant's ansible compatibility_mode Check and stop php7.1-fpm service Update to PHP 7.2 Fix failed_when in template_root check with wp-cli 1.5.0 (roots#948) Bump Ansible version_tested_max to 2.4.3.0 (roots#945) Update wp-cli to 1.5.0 (roots#944) Update `vagrant_box_version` to `>= 201801.02.0` Update `vagrant_box_version` to `<= 201801.02.0` Update Vagrant requirement to v2.0.1. Support for IPv6 in Letsencrypt challenges Allow Trellis VMs to be created/provisioned in Windows Subsystem for Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found no adjustments needed to accommodate Ansible 2.4.3.0.
However, @runofthemill kindly pointed out a problem on
vagrant upfor various Ansible versions:This PR adds a fix for this cosmetic problem, enabling the
replace_item_with_key()custom output method to handle tasks that usewith_dictandno_log.To avoid a long line, the fix uses a multiline conditional which can have funny formatting in python. I took the formatting approach here. However, the condition wouldn't be too terribly long on a single line, if preferred.