-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nginx: Compile dynamic modules #866
Conversation
4f52df0
to
a86e6ef
Compare
roles/nginx/defaults/main.yml
Outdated
@@ -15,3 +15,8 @@ nginx_cache_path: /var/cache/nginx | |||
nginx_cache_key_storage_size: 10m | |||
nginx_cache_size: 250m | |||
nginx_cache_inactive: 1h | |||
|
|||
# Dynamic modules | |||
nginx_deb_src: 'deb-src http://ppa.launchpad.net/nginx/development/ubuntu xenial main' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PPA is already set to this at the top of this file. So I would just remove any of your work for adding adding a deb-src but the rest looks okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come you don't get this error?
$ sudo apt-get source nginx
Reading package lists... Done
E: You must put some 'source' URIs in your sources.list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I didn't actually test these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems $ add-apt-repository --enable-source {{ nginx_ppa }}
is a better choice
784fce2
to
c37ee13
Compare
Updated:
|
c37ee13
to
8688b06
Compare
Will this be consider to be merged, or should I extract it to be a galaxy role? Thanks! |
Still undecided on this one. But I'm on vacation so not really thinking about this 😉 |
Closing this and continue on #867 because this seems won't be merged without |
I was actually thinking more about this last night and I'm probably fine with it :) I'll re-open and review it soon |
8688b06
to
7a244d1
Compare
More changes to lure you into it:
|
These commands works on my machine, not sure why it fails on travis: $ ansible-playbook --syntax-check -e env=development deploy.yml
$ ansible-playbook --syntax-check -e env=development dev.yml
$ ansible-playbook --syntax-check -e env=development server.yml |
@tangrufus: Can I use this for building the nginx pagespeed extension, too? |
I had trouble setting ngx_pagespeed as a dynamic module last August. It was a ngx_pagespeed issue. But from the latest doc, it seems working now. You can give it a try. This is untested and don't expect it will work without debugging:
|
this would be great to get merged - would allow Trellis to use https://github.com/masonicboom/ipscrub to reduce the surface area for GPDR issues |
Could https://github.com/ANXS/nginx somehow be re-used for this? |
@strarsis that looks like it'd require a major refactor, since currently nginx is built & configured without an |
Note:
nginx_dynamic_modules
is emptyUsage (see #867):
Related: #863