Lint: Fix `[301] Commands should not change things if nothing needs d…

…oing`
roots · Feb 16, 2020 · fec1a48 · fec1a48
1 parent 82438ad
commit fec1a48
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 0 deletions.
diff --git a/roles/common/tasks/reload_nginx.yml b/roles/common/tasks/reload_nginx.yml
@@ -2,6 +2,7 @@
 - name: reload nginx
   command: nginx -t
   notify: "{{ (role_path | basename == 'common') | ternary('perform nginx reload', omit) }}"
+  changed_when: false
 
 - name: perform nginx reload
   service:

diff --git a/roles/rollback/tasks/prior-release.yml b/roles/rollback/tasks/prior-release.yml
@@ -4,6 +4,7 @@
   args:
     chdir: "{{ project_root }}"
   register: current_release_position
+  changed_when: false
 
 - name: Fail if current release is the oldest available release
   fail:
@@ -15,6 +16,7 @@
   args:
     chdir: "{{ project_root }}"
   register: releases
+  changed_when: false
 
 - name: Create new_release_path variable
   set_fact:

diff --git a/roles/rollback/tasks/user-release.yml b/roles/rollback/tasks/user-release.yml
@@ -9,6 +9,7 @@
   args:
     chdir: "{{ project_root }}"
   register: current_release
+  changed_when: false
 
 - name: Fail if user-specified release doesn't exist or is already active
   fail:

diff --git a/roles/xdebug-tunnel/tasks/main.yml b/roles/xdebug-tunnel/tasks/main.yml
@@ -10,6 +10,7 @@
   become: no
   register: xdebug_tunnel
   ignore_errors: true
+  changed_when: false
 
 - name: Interpret and present Xdebug SSH tunnel errors
   fail: