Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix less breaking during watch on error #1342

Merged
merged 1 commit into from
Feb 24, 2015
Merged

Conversation

austinpray
Copy link
Contributor

If the --production flag is set: hard fail the build if there is a
precompiler error. If unset, log an error and end the task
successfully.

fixes #1288

@austinpray
Copy link
Contributor Author

@retlehs @JulienMelissas mind peeping this and seeing if it fixes the issue for you guys?

@JulienMelissas
Copy link
Contributor

I can confirm this is working now, ⚡ thanks @austinpray!

@austinpray austinpray force-pushed the fixWatch branch 2 times, most recently from cf078f9 to cc69e5e Compare February 24, 2015 01:01
If the `--production` flag is set: hard fail the build if there is a
precompiler error. If unset, log an error and end the task
successfully.

fixes roots#1288
@austinpray
Copy link
Contributor Author

ok should be rebased now

@retlehs
Copy link
Member

retlehs commented Feb 24, 2015

💙

retlehs added a commit that referenced this pull request Feb 24, 2015
fix less breaking during watch on error
@retlehs retlehs merged commit 1d4554f into roots:8.0.0 Feb 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants