Support specified netns and userns file paths #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Apr 18, 2019
AkihiroSuda
reviewed
Apr 18, 2019
|
thanks, could you also update man page? (edit slirp4netns.1.md and |
|
cc @giuseppe |
giuseppe
reviewed
Apr 18, 2019
amshinde
reviewed
Apr 18, 2019
|
Thank you for the feedback, working on the changes! My C coding is a bit... rusty to say the least :p |
gabibeyer
force-pushed
the
AddNSPath
branch
3 times, most recently
from
060264a to
97a7e2a
Compare
AkihiroSuda
reviewed
Apr 22, 2019
| @@ -295,6 +309,9 @@ struct options { | |||
| char *cidr; // --cidr | |||
| bool enable_ipv6; // -6 | |||
| char *api_socket; // -a | |||
| char *netns_type; // --netns-type | |||
| char *netns_path; // --netns-path | |||
AkihiroSuda
reviewed
Apr 22, 2019
slirp4netns.1.md
Outdated
|
|
||
| ```console | ||
| $ slirp4netns --userns-path=/path/to/userns ... | ||
| ``` |
There was a problem hiding this comment.
this example doesn't seem needed
|
looks good but a couple of nits |
Allow a network namespace path to be passed instead of a PID by using the --use-netns-path argument, and passing a path as the first argument. An optional --userns-path=PATH argument can be passed that will be supersede the default user namespace path. Fixes rootless-containers#84 Signed-off-by: Gabi Beyer <Gabrielle.n.beyer@intel.com>
AkihiroSuda
approved these changes
Apr 23, 2019
|
@giuseppe ptal |
|
LGTM |
|
Shall we release 0.3.1? 0.4.0? |
This was referenced Jul 23, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a network namespace path to be passed instead of a PID by
using the --use-netns-path argument, and passing a path as the
first argument. An optional --userns-path=PATH argument can be
passed that will be supersede the default user namespace path.
Fixes #84
Signed-off-by: Gabi Beyer Gabrielle.n.beyer@intel.com