Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Test with libslirp 4.3.1 on CentOS 7 #236

Closed

Conversation

mbargull
Copy link
Contributor

This is a followup to #234 (comment) :


@mbargull in #234 (comment) :

I did not investigate this further, so can't tell if it's kernel or ncat version related, but with libslirp 4.3.1 the --disable-dns did not show the expected timeout.

@AkihiroSuda in #234 (comment) :

timeout of what?

@mbargull in #234 (comment) :

https://github.com/rootless-containers/slirp4netns/blob/v1.1.6/tests/test-slirp4netns-disable-dns.sh#L33-L35 does not get a timeout message to grep for (the ncat seems to succeed).


@AkihiroSuda, I don't know if you'd want to investigate this further. I'm just opening this here for demonstrative purposes.
Feel free to amend or close!

@AkihiroSuda
Copy link
Member

Thanks, this seems to require investigation

@AkihiroSuda
Copy link
Member

The test may work after rebasing with master, which contains a7d99af

@mbargull
Copy link
Contributor Author

The test may work after rebasing with master, which contains a7d99af

IIRC, I tested it locally with that commit too and the ncat simply succeeded without outputting any timeout -- but it makes sense to rebase in any case!

@mbargull mbargull force-pushed the centos-libslirp-4.3 branch from 18aace9 to f5772c0 Compare November 25, 2020 09:45
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
@mbargull mbargull force-pushed the centos-libslirp-4.3 branch from f5772c0 to 2b98c47 Compare November 25, 2020 09:53
@AkihiroSuda
Copy link
Member

Vagrant itself uses 10.0.2.0/24, so it conflicts with slirp4netns 😭

@AkihiroSuda
Copy link
Member

Being fixed in #240

@mbargull
Copy link
Contributor Author

Oh dear, I doubt I would've noticed that as quickly as you did :D.
Thanks, superseded by gh-240.

@mbargull mbargull closed this Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants