Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable GitHub actions #165

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Enable GitHub actions #165

merged 1 commit into from
Dec 11, 2019

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Dec 4, 2019 •
edited
Loading

Fix #92

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Dec 4, 2019 •
edited
Loading

Seems can't be triggered on this repo until merging.

Triggered on my fork repo: https://github.com/AkihiroSuda/slirp4netns/commits/github-actions

@AkihiroSuda AkihiroSuda added the help wanted Extra attention is needed label Dec 4, 2019
@AkihiroSuda AkihiroSuda force-pushed the github-actions branch 5 times, most recently from 43a1fe5 to 7ec1176 Compare December 4, 2019 12:44
@AkihiroSuda AkihiroSuda removed the help wanted Extra attention is needed label Dec 4, 2019
This was referenced Dec 4, 2019
Merged
Merged
@AkihiroSuda
Enable GitHub actions
b02051f 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
AkihiroSuda commented Dec 4, 2019
View reviewed changes
.github/workflows/main.yaml
- uses: actions/upload-artifact@v1
with:
name: slirp4netns-x86_64
path: /tmp/artifact/slirp4netns
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this becomes zip :(

actions/upload-artifact#3

@AkihiroSuda
Copy link
Member Author

@rootless-containers/slirp4netns-approvers PTAL

@giuseppe
Copy link
Collaborator

I am not familiar with GH actions, but let's give it a try :-)

LGTM

@AkihiroSuda AkihiroSuda merged commit 1fea75f into rootless-containers:master Dec 11, 2019
@AkihiroSuda AkihiroSuda mentioned this pull request Dec 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

release pre-built binaries (using GitHub Actions, perhaps)
2 participants
@AkihiroSuda @giuseppe