TClass::GetListOfDataMembers reload list for struct/class when needed. #6668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting build on |
|
Build failed on ROOT-fedora31/noimt. Errors:
|
|
Build failed on ROOT-fedora30/cxx14. Errors:
And 2 more |
|
Build failed on ROOT-performance-centos8-multicore/default. Errors:
|
|
Build failed on ROOT-ubuntu16/nortcxxmod. Errors:
And 2 more |
|
Build failed on ROOT-debian10-i386/cxx14. Errors:
|
|
Build failed on windows10/cxx14. |
|
Build failed on mac1015/cxx17. Warnings:
|
|
Build failed on mac1014/python3. Errors:
|
The problem was due the introduction (in commit f3f0f13) of a fast path in TClass::GetListOfDataMember which did not take in consideration the case: c = GetClass(someclassname) c->GetState() == TClass::kForwardDeclared c->GetListOfDataMember() -> list is now created but empty. load and parse header file for c->GetState() == TClass::kInterpreted c->GetListOfDataMember() -> list is still empty but should have been filled (loaded at this point). The logic assumed incorrectly that if someclassname was indeed pointing to a class or struct and the list was created then it was loaded. To keep the fast path and correct the logic, we need to 'promote' TListOfDataMembers::fIsLoaded to be an std::atomic
|
Starting build on |
|
Build failed on mac1015/cxx17. Errors:
|
|
Build failed on windows10/cxx14. Failing tests: |
jblomer
requested changes
Oct 20, 2020
|
Yep. The test is in root-project/roottest#617 |
Closed
1 task
|
@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On |
|
Starting build on |
|
Build failed on ROOT-fedora31/noimt. Failing tests: |
|
Build failed on ROOT-performance-centos8-multicore/default. Failing tests: |
|
Build failed on ROOT-fedora30/cxx14. Failing tests: |
|
Build failed on mac1015/cxx17. Warnings:
Failing tests:
|
|
Build failed on mac1014/python3. Failing tests: |
|
Build failed on ROOT-debian10-i386/cxx14. Failing tests: |
|
@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On |
|
Starting build on |
|
Build failed on mac1015/cxx17. Errors:
|
jblomer
approved these changes
Oct 21, 2020
Axel-Naumann
approved these changes
Oct 21, 2020
|
The macos failure is unrelated (complains about an on-going git rebase). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was due the introduction (in commit f3f0f13) of a fast path in TClass::GetListOfDataMember which did not take in consideration the case:
c = GetClass(someclassname)
c->GetState() == TClass::kForwardDeclared
c->GetListOfDataMember() -> list is now created but empty.
load and parse header file for
c->GetState() == TClass::kInterpreted
c->GetListOfDataMember() -> list is still empty but should have been filled (loaded at this point).
The logic assumed incorrectly that if someclassname was indeed pointing to a class or struct and the list was created then it was loaded.
To keep the fast path and correct the logic, we need to 'promote' TListOfDataMembers::fIsLoaded to be an std::atomic