Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetTicks should be the analogous of SetTicks #14257

Merged
merged 3 commits into from
Dec 18, 2023
Merged

GetTicks should be the analogous of SetTicks #14257

merged 3 commits into from
Dec 18, 2023

Conversation

ferdymercury
Copy link
Contributor

This Pull request:

Changes or fixes:

SetTicks(GetTicks) was not a unity operator.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #14256

@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@ferdymercury ferdymercury requested a review from couet December 17, 2023 17:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2023 •
edited
Loading

Test Results

       10 files         10 suites   1d 22h 55m 23s ⏱️
  2 485 tests   2 485 ✔️ 0 💤 0 ❌
23 773 runs  23 773 ✔️ 0 💤 0 ❌

Results for commit 4c66e48.

♻️ This comment has been updated with latest results.

@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

guitargeek
guitargeek approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Since this is a bugfix, I'll also backport this to the 6.30 branch in one of my bulk backports, once this is merged.

@guitargeek guitargeek self-assigned this Dec 18, 2023
@guitargeek guitargeek added the bug label Dec 18, 2023
@ferdymercury ferdymercury added this to the 6.30.04 milestone Dec 18, 2023
@guitargeek guitargeek mentioned this pull request Dec 18, 2023
Closed
23 tasks
@guitargeek guitargeek merged commit 9397523 into root-project:master Dec 18, 2023
@guitargeek
Copy link
Contributor

guitargeek commented Dec 18, 2023 •
edited
Loading

Sorry, I just noticed I should have maybe squashed the commits, at least the third on the second because it was a fixup. My bad!

@ferdymercury ferdymercury deleted the ticks branch December 18, 2023 12:56
@guitargeek guitargeek mentioned this pull request Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guitargeek guitargeek guitargeek approved these changes

@lmoneta lmoneta Awaiting requested review from lmoneta lmoneta is a code owner

@couet couet Awaiting requested review from couet

Assignees

@guitargeek guitargeek

Labels
bug
Projects
None yet
Milestone
6.30.04
Development

Successfully merging this pull request may close these issues.

TAxis::GetTicks and TAxis::SetTicks are inconsistent. Significantly so.
3 participants
@ferdymercury @phsft-bot @guitargeek