-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thisroot.sh: if exe contains qemu, use /proc/$$/comm instead #14251
Conversation
Can one of the admins verify this patch? |
Not an admin, but I tested it and it does fix #14085 |
@phsft-bot build |
Starting build on |
I'd leave the backport decision up to you. We can patch this into our user environments without a backport too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! If this fixes the shell detection when using qemu, then it should be merged 👍
Ok, I prefer backports over people patching ROOT 🙂 There is a very low risk of breaking something here, since the PF only affects the case where |
This Pull request:
This PR aims to address #14085 by making thisroot.sh identify the shell correctly even when run under qemu, for example in emulated docker containers.
Changes or fixes:
When qemu is run, then
/proc/$$/comm
contains the name of the command that is emulated.Checklist:
updated the docs (if necessary)N/AThis PR fixes #14085.
Tests
Before:
After: