Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust test for failures on aarch64, ppc64le and s390x #14164

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Adjust test for failures on aarch64, ppc64le and s390x #14164

merged 1 commit into from
Dec 3, 2023

Conversation

ellert
Copy link
Contributor

@ellert ellert commented Dec 2, 2023

This Pull request:

Changes or fixes:

[ RUN      ] RooTruthModel.IntegrateSubrange
[#1] INFO:Eval -- RooRealVar::setRange(dt) new range named 'integral' created with bounds [2,2]
/builddir/build/BUILD/root-6.30.02/roofit/roofitcore/test/testRooTruthModel.cxx:38: Failure
Expected equality of these values:
  integ->getVal()
    Which is: -2.8822093e-17
  0.0
    Which is: 0
[  FAILED  ] RooTruthModel.IntegrateSubrange (194 ms)

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@ellert
Adjust test for failures on aarch64, ppc64le and s390x
8e6b901 
[ RUN      ] RooTruthModel.IntegrateSubrange
[#1] INFO:Eval -- RooRealVar::setRange(dt) new range named 'integral' created with bounds [2,2]
/builddir/build/BUILD/root-6.30.02/roofit/roofitcore/test/testRooTruthModel.cxx:38: Failure
Expected equality of these values:
  integ->getVal()
    Which is: -2.8822093e-17
  0.0
    Which is: 0
[  FAILED  ] RooTruthModel.IntegrateSubrange (194 ms)
@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2023

Test Results

         7 files           7 suites   1d 2h 29m 41s ⏱️
  2 483 tests   2 482 ✔️ 0 💤 1 ❌
16 448 runs  16 447 ✔️ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 8e6b901.

@guitargeek guitargeek mentioned this pull request Dec 3, 2023
Closed
23 tasks
guitargeek
guitargeek approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution! I will also backport this PR so it makes it into the upcoming ROOT 6.30.04 release.

@guitargeek guitargeek merged commit ad2bc93 into root-project:master Dec 3, 2023
@guitargeek guitargeek mentioned this pull request Dec 3, 2023
Merged
@ellert ellert deleted the cmp-zero branch December 5, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guitargeek guitargeek guitargeek approved these changes

@lmoneta lmoneta Awaiting requested review from lmoneta lmoneta is a code owner

@hageboeck hageboeck Awaiting requested review from hageboeck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ellert @phsft-bot @guitargeek