This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_lsp): don't throw error for ignored files in code actions #4443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4434
I also took the opportunity to refactor how "features" are requested from a workspace. So far, requesting a feature was done via
.supports_feature
, and it was possible only to ask for a "feature" per file.I refactored the code; now it's possible to request multiple features. The result of the function also provides some APIs to ask if a file supports a single "feature".
The concept of
supports_feature
has been renamed tofile_features
.Test Plan
I created a new test for the bug.
The refactor should not have any regression, so the existing tests should all pass.
Changelog
Documentation