feat(theme): allow override redoc theme inside docusaurus.config file #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 717d36b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rohit-gohri
reviewed
Feb 25, 2022
There was a problem hiding this comment.
This overall looks great! Thanks for the PR, this will actually close #98 I think.
Can you also update the readme of the theme package and add this new option there? Maybe with a warning that this might break dark theme overrides.
Thanks for pointing out the nodemon thing, I have it installed globally so didn't notice it. Will fix it.
| * NOTE: Variables taken from infima | ||
| * @see https://github.com/facebookincubator/infima/blob/master/packages/core/styles/common/variables.pcss | ||
| */ | ||
| const LIGHT_THEME_OPTIONS: RedocThemeOverrides = { |
There was a problem hiding this comment.
Nice refactor! Good idea to separate font and colors
rohit-gohri
approved these changes
Feb 25, 2022
Merged
|
Released as v0.8.0! Thank you for the PR |
|
Thanks ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey !
I spent a little bit of time on your lib. It's cool, great work !
I added an attribute inside docusaurus.config file, named
redocTheme, to allow deep modification of the redoc theme.I'm open if you have something else in your mind for this var.
I also lint the project so the file
/home/leo/CS/rs-dev/redocusaurus/packages/docusaurus-theme-redoc/src/theme/ServerStyle/index.tsxis also bringed by this PR.Some notes
You should note that
nodemonis used in your package.json but is not inside dev dependencies.But anyway, the command
yarn devis not working on my side, I have no output...When I hit Ctrl+C it shows the log :
Hopefully
yarn buildis OK.I first tryed to develop this feature using my real Webapp with symlink to your modules, but it was hell 🔥. So I will wait you accept and publish this PR
Maintainer notes:
Closes #98