Put trampolines in original class namespace #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
virtuald
commented
Dec 18, 2024
virtuald
commented
- This simplifies wrapping somewhat and avoids compile errors when the trampoline references a class in a parent namespace
- This is a breaking change -- bindings need to be recompiled to match each other
- This simplifies wrapping somewhat and avoids compile errors when the trampoline references a class in a parent namespace - This is a breaking change -- bindings need to be recompiled to match each other
virtuald
force-pushed
the
trampoline-ns
branch
from
5fed2c2 to
4efad83
Compare
- Previously the name included the namespace, but now they're in the target namespace so it's just redundant information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.