Update README.md #2105
Merged
Update README.md #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added examples in Readme.md for fetching values from Remote
mumoshu
reviewed
Mar 25, 2022
| staging: | ||
| values: | ||
| - git::https://{{ env "GITHUB_PAT" }}@github.com/[$GITHUB_ORGorGITHUB_USER]/repository-name.git@/values.dev.yaml?ref=main #Github Private repo | ||
| - http://$HOSTNAME/artifactory/example-repo-local/test.tgz@values.yaml #Artifactory url |
There was a problem hiding this comment.
Suggested change
| - http://$HOSTNAME/artifactory/example-repo-local/test.tgz@values.yaml #Artifactory url | |
| - http://my_artifactory_server/artifactory/example-repo-local/test.tgz@values.yaml #Artifactory url |
Nit but it might better use a placeholder that looks not like a variable so that first-time users won't misunderstand if one can use shell variables within helmfile.yaml 😃
mumoshu
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added examples in Readme.md for fetching values from Remote