Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more examples for remote env value files #1938

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Add more examples for remote env value files #1938

merged 1 commit into from
Sep 13, 2021

Conversation

reixd
Copy link
Contributor

@reixd reixd commented Aug 10, 2021

I had difficulties loading remote value files even after looking at the docs here and go-getter.
The solution was in the test code here:

// We use `@` to separate dir and the file path. This is a good idea borrowed from helm-git:

Use an @ to separate the path from the GIT url...

To help others I want to update the docs with the solution which worked for me ;-)

@@ -854,17 +854,21 @@ environments:
values:
- git::https://git.company.org/helmfiles/global/azure.yaml?ref=master
- git::https://git.company.org/helmfiles/global/us-west.yaml?ref=master
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm now wondering if this was never correct 🤔 Perhaps it should be git::https://git.company.org/helmfiles@global/us-west.yaml?ref=master ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you need to use the @ to separate the folder from the URL.

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch! I do often forget about the fact that we need to use @ myself, so this's a great addition. Thanks for your contribution @reixd

@mumoshu mumoshu merged commit ae438c8 into roboll:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants