-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users other than root to use helm plugins #1766
Conversation
Hi @mumoshu, what do you think about that? |
@aperigault Hey! Thanks. Honestly speaking I don't understand for what usecase this can be helpful. How did you test this? What was your example usecase and the exact docker-run command you used to verify this? |
Or maybe you tried to complement #1134 (comment) and tried to fix #1134 (comment)? |
Hi! |
Hi @mumoshu, do you think this is a good workaround ? |
As already mentioned by a couple of users here, the current Helmfile image is pretty useless in many cases. I tried to use it in a Jenkins pipeline and there is either a permission problem and if you adjust the UID / GID to a non-root user, you cannot use the Helm plugins. A more clean approach than in this PR, would probably be to set the For those who stumble across the tickets here or this PR, I recommend using the Helmfile image by Jenkins. https://github.com/jenkins-infra/docker-helmfile The only thing I needed to adjust was overriding the entrypoint ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if forcing everyone to use non-root user within a helmfile container is the right thing to do either, as it might limit debugging operations within the container. Or perhaps I'm still missing something? 🤔
Probably this is a good workaround. This is almost a year old but it's better done than nothing! Thanks for your feedback and contribution. Merging.
Resolves roboll#1134 Co-authored-by: Antony Perigault <antony.perigault@cpexterne.org>
Hi,
as discussed in this issue #1134, I propose to allow all users to go through root directory to be able to use helm plugins in container running as non root users.