Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v2024.3.4 #206

Merged
merged 2 commits into from
Feb 13, 2025
Merged

release: v2024.3.4 #206

merged 2 commits into from
Feb 13, 2025

Conversation

rustatian
Copy link
Member

@rustatian rustatian commented Feb 13, 2025

Reason for This PR

  • Release cycle.

Description of Changes

  • Plugins were updated to their latest versions (velox.toml).
  • Dockerfile + builds updated to Go 1.24.
  • Update the build template to support Go 1.24.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Summary by CodeRabbit

  • Chores
    • Upgraded core tooling and build environments with the latest stable versions to enhance reliability and performance.
    • Updated code quality checks and dependency management workflows for improved consistency.
    • Refreshed numerous dependency and plugin versions to maintain compatibility with current standards.
    • Adjusted version control settings to exclude local development environment artifacts for a cleaner repository.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. R-stable Release: Nominated for backporting to the RR in the stable channel. labels Feb 13, 2025
@rustatian rustatian requested a review from wolfy-j February 13, 2025 18:53
@rustatian rustatian self-assigned this Feb 13, 2025
Copy link

coderabbitai bot commented Feb 13, 2025

Walkthrough

This pull request makes several version updates across configuration and source files. The GitHub Actions linters workflow is updated with newer versions of the linting action and the linter itself. A new entry is added to the .gitignore to ignore Python virtual environment directories. The Dockerfile’s base image and a Go module constant in a template file have been updated to a newer Go version. Additionally, multiple version bumps are applied in the velox.toml configuration for various plugins.

Changes

File(s) Change Summary
.github/workflows/linters.yml Updated golangci-lint-action from v6.3.2 to v6.3.3 and linter version from v1.62 to v1.64.
.gitignore Added new entry .venv to ignore the virtual environment directory.
Dockerfile Changed builder base image from golang:1.23-alpine to golang:1.24-alpine, thereby updating the Go version used during the build process.
builder/templates/…/templateV2024.go Updated the GoModTemplateV2024 constant to change the Go version from 1.22 to 1.24.
velox.toml Incremented version references for roadrunner and various plugins (e.g., appLogger, logger, temporal, static, http, kv, etc.) to newer patch versions.

Possibly related PRs

Suggested labels

dependencies, docker

Suggested reviewers

  • wolfy-j

Poem

I'm a rabbit with a spring in my hop,
Bumping versions, making code jump non-stop.
Docker and lint, they're all set anew,
My little paws approved each change in view.
Hopping through updates with a joyful heart – let’s code smart!
🐇

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 golangci-lint (1.62.2)

Error: can't load config: the Go language version (go1.23) used to build golangci-lint is lower than the targeted Go version (1.24.0)
Failed executing command with error: can't load config: the Go language version (go1.23) used to build golangci-lint is lower than the targeted Go version (1.24.0)


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c2c821 and fc6ab59.

📒 Files selected for processing (5)
  • .github/workflows/linters.yml (1 hunks)
  • .gitignore (1 hunks)
  • Dockerfile (1 hunks)
  • builder/templates/templateV2024.go (1 hunks)
  • velox.toml (2 hunks)
✅ Files skipped from review due to trivial changes (4)
  • .gitignore
  • .github/workflows/linters.yml
  • Dockerfile
  • builder/templates/templateV2024.go
🔇 Additional comments (3)
velox.toml (3)

1-2: LGTM! Core RoadRunner version update.

The RoadRunner core version is being updated from v2024.3.3 to v2024.3.4, which aligns with this release PR.


185-188: LGTM! Test plugin configuration remains unchanged.

The test plugin configuration is maintained with the same repository ID, which is appropriate for this version update PR.


20-183:

✅ Verification successful

Verify version compatibility across plugins.

Most plugins are being updated to v5.1.4, with a few exceptions:

  • temporal: v5.5.1
  • http: v5.2.3
  • static & send: v5.1.3
  • server: v5.2.5
  • kv & memory: v5.2.4

The version differences appear intentional based on the plugin's release cycles.

Let's verify the latest releases of these plugins to ensure we're using the most recent stable versions:


🏁 Script executed:

#!/bin/bash
# Description: Check the latest releases for key plugins

# Function to fetch latest release
get_latest_release() {
    local owner=$1
    local repo=$2
    gh api repos/$owner/$repo/releases/latest --jq '.tag_name'
}

echo "Checking latest releases..."
echo "temporal: $(get_latest_release temporalio roadrunner-temporal)"
echo "http: $(get_latest_release roadrunner-server http)"
echo "static: $(get_latest_release roadrunner-server static)"
echo "server: $(get_latest_release roadrunner-server server)"
echo "kv: $(get_latest_release roadrunner-server kv)"

Length of output: 1116


Plugin versions verified: No changes needed.

The output from the verification script confirms that the versions for the plugins are aligned with the latest stable releases. Specifically:

  • temporal: v5.5.1
  • http: v5.2.3
  • static: v5.1.3
  • server: v5.2.5
  • kv: v5.2.4

The intentional version differences for the other plugins also remain consistent with the expected release cycles. Therefore, the plugin configuration in velox.toml is correct and no modifications are required.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rustatian rustatian merged commit 0e1aed8 into master Feb 13, 2025
6 of 7 checks passed
@rustatian rustatian deleted the release/v2024.3.4 branch February 13, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. R-stable Release: Nominated for backporting to the RR in the stable channel.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant