perf(encoding): add estimate size for value encoding #8692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st1page
commented
Mar 21, 2023
Comment on lines
236
to
256
| fn estimate_encoded_scalar_size(value: ScalarRefImpl<'_>) -> usize { | ||
| match value { | ||
| ScalarRefImpl::Int16(_) => 2, | ||
| ScalarRefImpl::Int32(_) => 4, | ||
| ScalarRefImpl::Int64(_) => 8, | ||
| ScalarRefImpl::Serial(_) => 8, | ||
| ScalarRefImpl::Float32(_) => 4, | ||
| ScalarRefImpl::Float64(_) => 8, | ||
| ScalarRefImpl::Utf8(v) => v.as_bytes().len(), | ||
| ScalarRefImpl::Bytea(v) => estimate_encoded_str_size(v), | ||
| ScalarRefImpl::Bool(_) => 1, | ||
| ScalarRefImpl::Decimal(_) => estimate_encoded_decimal_size(), | ||
| ScalarRefImpl::Interval(_) => estimate_encoded_interval_size(), | ||
| ScalarRefImpl::NaiveDate(_) => estimate_encoded_naivedate_size(), | ||
| ScalarRefImpl::NaiveDateTime(_) => estimate_encoded_naivedatetime_size(), | ||
| ScalarRefImpl::NaiveTime(_) => estimate_encoded_naivetime_size(), | ||
| ScalarRefImpl::Jsonb(_) => 8, | ||
| ScalarRefImpl::Struct(s) => estimate_encoded_struct_size(s), | ||
| ScalarRefImpl::List(v) => estimate_encoded_list_size(v), | ||
| } | ||
| } |
There was a problem hiding this comment.
maybe we can refactor it with macro or other techs in future PRs.
Codecov Report
@@ Coverage Diff @@
## main #8692 +/- ##
==========================================
+ Coverage 71.06% 71.07% +0.01%
==========================================
Files 1166 1166
Lines 192345 192454 +109
==========================================
+ Hits 136691 136792 +101
- Misses 55654 55662 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wangrunji0408
approved these changes
Mar 21, 2023
|
|
You can write some datums, encode them, and compare with your pre-calculated result. |
we can not get the exact size for the jsonb 😿 |
54 tasks
TennyZhuang
reviewed
Mar 27, 2023
TennyZhuang
approved these changes
Mar 27, 2023
Co-authored-by: TennyZhuang <zty0826@gmail.com>
This was referenced Mar 28, 2023
kwannoel
reviewed
Mar 30, 2023
| if let Some(d) = datum_ref.to_datum_ref() { | ||
| 1 + estimate_serialize_scalar_size(d) | ||
| } else { | ||
| 1 |
There was a problem hiding this comment.
I guess 1 here is to store the null u8 flag?
fuyufjh
reviewed
Mar 30, 2023
| ScalarRefImpl::NaiveDate(_) => estimate_serialize_naivedate_size(), | ||
| ScalarRefImpl::NaiveDateTime(_) => estimate_serialize_naivedatetime_size(), | ||
| ScalarRefImpl::NaiveTime(_) => estimate_serialize_naivetime_size(), | ||
| ScalarRefImpl::Jsonb(_) => 8, |
There was a problem hiding this comment.
It’s heavy to pre-compute the size of jsonb, but anyway, 8 is too small and we need some comments here.
There was a problem hiding this comment.
🤔 I will leave an issue to bench and trade-off if it is worth estimating the jsonb's size. @st1page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
add function to estimate the value encoding size of the datum
prepare for #8683
Checklist For Contributors
./risedev check(or alias,./risedev c)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note