feat(optimizer): optimizing vanilla min/max on index/pk
#8337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clearlove <yifei.c.wei@gmail.com>
Signed-off-by: Clearlove <yifei.c.wei@gmail.com>
y-wei
changed the title
min/max on index/pkmin/max on index/pk
chenzl25
approved these changes
Mar 6, 2023
Comment on lines
239
to
249
| static ref AGG_ON_INDEX: OptimizationStage = OptimizationStage::new( | ||
| static ref TOP_N_ON_INDEX: OptimizationStage = OptimizationStage::new( | ||
| "Agg on Index", | ||
| vec![TopNOnIndexRule::create()], | ||
| ApplyOrder::TopDown, | ||
| ); | ||
|
|
||
| static ref MIN_MAX_ON_INDEX: OptimizationStage = OptimizationStage::new( | ||
| "Min/Max on Index", | ||
| vec![MinMaxOnIndexRule::create()], | ||
| ApplyOrder::TopDown, | ||
| ); |
There was a problem hiding this comment.
Could you please merge these two stages? I intend to group rules that serve a similar function together.
There was a problem hiding this comment.
Thanks for pointing this out!
BugenZhao
reviewed
Mar 6, 2023
Co-authored-by: Bugen Zhao <i@bugenzhao.com>
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Clearlove yifei.c.wei@gmail.comI hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Vanilla
minandmaxon index/pk for batch execution is optimized.An optimizer rule
MinMaxOnIndexRulethat optimizes "no group key, no distinct, no filter, no order_by, single-fielded"minandmax.Checklist For Contributors
./risedev check(or alias,./risedev c)Checklist For Reviewers
Related Issues
#7991, #7481