Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta): do configuration change in single barrier #20493

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Feb 13, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Finalize and resolve #18312.

In this PR, we will

  • Change to run all barrier manager commands with a single barrier, and the previous pause-change-resume mechanism will be removed.
  • The PausedReason will be removed, and the pause and resume command will not hold a PausedReason
  • We won't stop inject barrier when there is an inflight pause barrier
  • The wait_epoch_committed rpc will be removed
  • Newly created actors during configuration will start working immediately instead of pause on bootstrap.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Copy link

gru-agent bot commented Feb 13, 2025

❌ Rebase test pr failed: Error: Pull request #20493 is not created by gru-agent[bot]

Copy link
Contributor Author

wenym1 commented Feb 13, 2025

@wenym1 wenym1 force-pushed the yiming/wait-epoch-when-update-vnode-bitmap branch from ee10be7 to 079b77c Compare February 14, 2025 07:00
@wenym1 wenym1 force-pushed the yiming/use-single-barrier-configuration-change branch 3 times, most recently from 2dbb354 to 2537f22 Compare February 17, 2025 04:17
@wenym1 wenym1 changed the base branch from yiming/wait-epoch-when-update-vnode-bitmap to yiming/wait-committed-epoch-on-source-split-change February 17, 2025 04:17
Base automatically changed from yiming/wait-committed-epoch-on-source-split-change to main February 20, 2025 08:45
@wenym1 wenym1 force-pushed the yiming/use-single-barrier-configuration-change branch from 2537f22 to ad38833 Compare February 20, 2025 09:13
@wenym1 wenym1 changed the base branch from main to yiming/wait-epoch-when-update-vnode-bitmap February 20, 2025 09:13
@wenym1 wenym1 force-pushed the yiming/wait-epoch-when-update-vnode-bitmap branch from 832be59 to 5bcc36c Compare February 25, 2025 05:12
@wenym1 wenym1 force-pushed the yiming/use-single-barrier-configuration-change branch from ad38833 to f7883df Compare February 25, 2025 05:12
Base automatically changed from yiming/wait-epoch-when-update-vnode-bitmap to main February 25, 2025 06:48
@wenym1 wenym1 force-pushed the yiming/use-single-barrier-configuration-change branch from f7883df to 620c2e5 Compare February 26, 2025 04:15
@wenym1 wenym1 changed the base branch from main to yiming/fix-log-store-scale-data-loss February 26, 2025 04:15
@wenym1 wenym1 force-pushed the yiming/fix-log-store-scale-data-loss branch from f421f54 to 856ea07 Compare February 26, 2025 08:05
@wenym1 wenym1 force-pushed the yiming/use-single-barrier-configuration-change branch from c4d9946 to e2009bc Compare February 26, 2025 08:06
Base automatically changed from yiming/fix-log-store-scale-data-loss to main February 27, 2025 04:53
@wenym1 wenym1 force-pushed the yiming/use-single-barrier-configuration-change branch from 214fd61 to 7709bfc Compare February 27, 2025 08:35
@wenym1 wenym1 force-pushed the yiming/use-single-barrier-configuration-change branch from 7709bfc to c1a22bb Compare February 27, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support configuration change in a single barrier
1 participant