Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve error msg for sink into table #19728

Closed
wants to merge 1 commit into from
Closed

feat: improve error msg for sink into table #19728

wants to merge 1 commit into from

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Dec 10, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

non-appendonly sink

> create table t(x int); create table tt(x int); create sink s into tt from t;
CREATE_TABLE
CREATE_TABLE
ERROR:  Failed to run the query

Caused by:
  Bind error: Only append-only sinks can sink to a table without primary keys. This sink is not append-only.
Please try to add (type = 'append-only', force_append_only = 'true') to the WITH options.

TODO: when type='append-only' is not specified, it's considered upsert.. We should improve that.

append-only sink

> create table t(x int); create table tt(x int); create sink s into tt as with t as changelog from t select x from t;

BEFORE:

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: xxchan <xxchan22f@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant