-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include subject in NATS source #19708
feat: include subject in NATS source #19708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea LGTM. Please also take a look cc. @tabVersion @xiangjinwu
Hi @PierreNowak , I submit a pr to fix the format issue and add nats related E2E test. |
fix: add nats e2e test and format fix
Hi @PierreNowak, can you merge PierreNowak#2 on your branch to merge this one? Thanks |
fix: resolve conflict
5a85b55
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Ingest additional subject field for NATS source
now I have my subject column:
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
as describe in title
support additional column dedicated to Nats Connector
subject
stands for the message comes from which subject if the stream contains multiple subjects.