fix(compaction): support trivial reclaim #10258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
zwang28
approved these changes
Jun 12, 2023
| return Some(CompactionInput { | ||
| input_levels: vec
Li0k
reviewed
Jun 12, 2023
| }); | ||
| } | ||
| } | ||
| state.last_level = 1; |
There was a problem hiding this comment.
how about change state.last_level = 1 -> state.last_level = base_level if convenient
Li0k
reviewed
Jun 12, 2023
src/storage/hummock_sdk/src/compaction_group/hummock_version_ext.rs
Outdated
Show resolved
Hide resolved
src/storage/hummock_sdk/src/compaction_group/hummock_version_ext.rs
Outdated
Show resolved
Hide resolved
|
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Little-Wallace
added a commit
to Little-Wallace/risingwave
that referenced
this pull request
Jun 21, 2023
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
7 tasks
zwang28
pushed a commit
that referenced
this pull request
Jun 27, 2023
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
fix #10215
This PR will create reference for every sstable files in group-split. It means that a large group can not reduce the number of sstable files at the time when it splits a large table to an independent group. We will use space-reclaim compaction to reduce the number of files after group split.
I add a compatibility field in hummock.proto to ensure this change would not affect those risingwave cluster which upgrade from an old version. If the version-delta was generated by the old binary, it would still move all files which have no data of valid table-id to new group.
Checklist For Contributors
./risedev check(or alias,./risedev c)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note