Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate use of compact in aggregation executor #9150

Open
Tracked by #7792 ...
kwannoel opened this issue Apr 13, 2023 · 3 comments
Open
Tracked by #7792 ...

Investigate use of compact in aggregation executor #9150

kwannoel opened this issue Apr 13, 2023 · 3 comments

Comments

@kwannoel
Copy link
Contributor

kwannoel commented Apr 13, 2023

I think to get another datapoint on whether to compact or not we can do the following:

  1. Construct a case where selectivity is 100%
  2. Compact
  3. See what's the overhead via criterion.
  4. Can also get precise overhead in a flamegraph + run criterion.

Can use stream hash agg benchmark / streaming fold agg to measure this.

This serves as a baseline for #9148

@kwannoel kwannoel changed the title Investigate use of compact in aggregation executor. Investigate use of compact in aggregation executor Apr 13, 2023
@github-actions github-actions bot added this to the release-0.19 milestone Apr 13, 2023
@st1page
Copy link
Contributor

st1page commented Apr 20, 2023

#9300

@github-actions
Copy link
Contributor

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

Copy link
Contributor

github-actions bot commented Jul 3, 2024

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean.
Don't worry if you think the issue is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants