Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Optimize Bitmap Iter #9148

Closed
kwannoel opened this issue Apr 13, 2023 · 2 comments
Closed

perf: Optimize Bitmap Iter #9148

kwannoel opened this issue Apr 13, 2023 · 2 comments
Assignees
Milestone

Comments

@kwannoel
Copy link
Contributor

#7792 (comment)

  1. Instead of using iterators, just loop over chunk + bitmap directly. Iterators have at least 1 jmp for checking if there's any items left. So with 2 iterators we have 2 jmp (if not optimized away). See if this improves things.
  2. Bench with and without caching step for bitmap iter, see how things change for q17 benchmark / streaming fold agg.

Let me know if any further details are required, I can definitely provide more elaboration.

@github-actions github-actions bot added this to the release-0.19 milestone Apr 13, 2023
@kwannoel kwannoel changed the title Optimize Bitmap Iter perf: Optimize Bitmap Iter Apr 13, 2023
@kwannoel
Copy link
Contributor Author

kwannoel commented Apr 13, 2023

Here's the baseline that is expected: #9129. Around a 5% improvement in the hashagg q17 bench when we do compact.

If BitmapIter optimization does better, we should definitely use it instead.

@kwannoel
Copy link
Contributor Author

This can be closed, bitmapiter no longer shows up in flamegraph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants